You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/28 22:37:19 UTC
[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #242: [YUNIKORN-461] remove allocations list from partition
yangwwei commented on a change in pull request #242:
URL: https://github.com/apache/incubator-yunikorn-core/pull/242#discussion_r566452486
##########
File path: pkg/scheduler/partition.go
##########
@@ -61,6 +59,7 @@ type PartitionContext struct {
userGroupCache *security.UserGroupCache // user cache per partition
totalPartitionResource *resources.Resource // Total node resources
nodeSortingPolicy *policies.NodeSortingPolicy // Global Node Sorting Policies
+ allocations int // Number of allocations on the partition
Review comment:
why we still need to track the number of allocations?
if this is just for UT, I think we should remove them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org