[GitHub] [rocketmq] duhenglucky commented on a diff in pull request #4457: [ISSUE #4426]fix ACL issue when sending messages back

[GitBox <gi...@apache.org>]

duhenglucky commented on code in PR #4457:
URL: https://github.com/apache/rocketmq/pull/4457#discussion_r896298938


##########
acl/src/test/java/org/apache/rocketmq/acl/plain/PlainAccessValidatorTest.java:
##########
@@ -132,7 +133,28 @@ public void validateSendMessageTest() {
         buf = ByteBuffer.allocate(buf.limit() - buf.position()).put(buf);
         buf.position(0);
         try {
-            PlainAccessResource accessResource = (PlainAccessResource) plainAccessValidator.parse(RemotingCommand.decode(buf), "192.168.0.1");
+            PlainAccessResource accessResource = (PlainAccessResource) plainAccessValidator.parse(RemotingCommand.decode(buf), "123.4.5.6");

Review Comment:
   There is an assumption here, that is, the user does not have a customized retry topic usage mode,  Of course, this is not the focus of our concern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org