You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by karuturi <gi...@git.apache.org> on 2015/09/22 11:39:51 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/873
CLOUDSTACK-8896: allocated percentage of storage pool going beyond 100%
This issue occurs when a volume in Ready state is moved across storage
pools.
While finding if the storage pool has enough space, it has a check to
consider the size of non Ready volumes only. This is true if the volume
to be attached to a vm is in the same storage pool. But, if the volume
is in another storage pool and has to be moved to a vm's storage pool,
the size of the volume should be considered in doing the space check.
computing the asking size when volume is not in ready state or when the
volume is on a different storage pool.
Testing:
I couldnt write unittests for it. This class is not in a unittestable state.
manually tested in the below environment
1. xenserver 6.5 setup with 2 clusters and a host each in each of them.
2. added storage tags for the primary storage.
3. created two service offerings with the storage tags.
4. deployed two vms using newly created offerings in step 3.
5. at this stage, there are two vms one on each host with root disks on the corresponding primary.
6. create a data disk and attach it to vm1
7. detach the data disk. now the data disk is in the primary storage of the cluster of vm1 (let us say primary1)
8. attach this data disk to vm2(running on a host in different cluster)
9. the volume should be moved to the primary storage of another cluster and op_host_capacity should be accordingly updated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-8896
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/873.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #873
----
commit 5d8fd6e9acdc6b28d6a14b092290483614f412b3
Author: Rajani Karuturi <ra...@citrix.com>
Date: 2015-09-22T09:27:38Z
CLOUDSTACK-8896: allocated percentage of storage pool going beyond 100%
This issue occurs when a volume in Ready state is moved across storage
pools.
While finding if the storage pool has enough space, it has a check to
consider the size of non Ready volumes only. This is true if the volume
to be attached to a vm is in the same storage pool. But, if the volume
is in another storage pool and has to be moved to a vm's storage pool,
the size of the volume should be considered in doing the space check.
setting the asking size when volume is not in ready state or when on a
different storage pool.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r41697351
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool)
allocatedSizeWithtemplate = _capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
}
}
- if (volumeVO.getState() != Volume.State.Ready) {
+ // A ready state volume is already allocated in a pool. so the asking size is zero for it.
+ // In case the volume is moving across pools or is not ready yet, the asking size has to be computed
+ s_logger.debug("pool id for the volume with id: " + volumeVO.getId() + " is: " + volumeVO.getPoolId());
--- End diff --
I guess there is no consensus or guideline around logging ids in debug logs (uuids vs ids) though I've seen most logs messages using IDs instead of UUIDs (perhaps because most code relied on IDs than UUIDs, as UUIDs were introduced only in that last 2 years or so).
Though the logged message is not verbose enough wrt what it was doing, may be you can add some context to say what it is doing etc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/873
I tried rebasing to 4.8 but there were conflicts. rebased it against 4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@karuturi can you please rebase this against latest master, let's get this reviewed and merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #873: CLOUDSTACK-8896: allocated percentage of stora...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r90589284
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1719,6 +1719,7 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool,
}
// allocated space includes templates
+ s_logger.debug("Destination pool id: " + pool.getId());
--- End diff --
Please wrap this `DEBUG` log in an `if (s_logger.isDebugEnabled)` check to prevent unnecessary/expensive string concatenation when `DEBUG` logging is not enabled. Also, please add context to message to explain what operation is being performed for the destination pool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r40881830
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool)
allocatedSizeWithtemplate = _capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
}
}
- if (volumeVO.getState() != Volume.State.Ready) {
+ // A ready state volume is already allocated in a pool. so the asking size is zero for it.
+ // In case the volume is moving across pools or is not ready yet, the asking size has to be computed
+ s_logger.debug("pool id for the volume with id: " + volumeVO.getId() + " is: " + volumeVO.getPoolId());
--- End diff --
@wido numeric ids in logs are easy to understand/debug than uuids. names might me more readable but ids are unique and hence no ambiguity.
The current pool-id is already logged and the pool-id of the the volume would help me see if the volume is moving across pools. That was the information I was looking for while debugging this issue and was hard to find given nothing was logged before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r40195709
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool)
allocatedSizeWithtemplate = _capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
}
}
- if (volumeVO.getState() != Volume.State.Ready) {
+ // A ready state volume is already allocated in a pool. so the asking size is zero for it.
+ // In case the volume is moving across pools or is not ready yet, the asking size has to be computed
+ s_logger.debug("pool id for the volume with id: " + volumeVO.getId() + " is: " + volumeVO.getPoolId());
--- End diff --
Could you make this line a bit more descriptive? To me it doesn't seem like a very useful line when running in debug mode.
Also, do we want the numeric IDs here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
<b>Trillian test result (tid-519)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27196 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr873-t519-kvm-centos7.zip
Test completed. 46 look ok, 2 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 870.17 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 379.81 | test_vpc_redundant.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 245.11 | test_internal_lb.py
ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 535.18 | test_vpc_redundant.py
test_01_vpc_site2site_vpn | Success | 165.81 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 81.27 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 341.36 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 323.55 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 608.23 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 530.07 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1421.98 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 575.32 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.60 | test_volumes.py
test_08_resize_volume | Success | 15.36 | test_volumes.py
test_07_resize_fail | Success | 20.47 | test_volumes.py
test_06_download_detached_volume | Success | 15.37 | test_volumes.py
test_05_detach_volume | Success | 100.29 | test_volumes.py
test_04_delete_attached_volume | Success | 10.19 | test_volumes.py
test_03_download_attached_volume | Success | 15.28 | test_volumes.py
test_02_attach_volume | Success | 73.73 | test_volumes.py
test_01_create_volume | Success | 712.51 | test_volumes.py
test_deploy_vm_multiple | Success | 248.44 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.80 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.24 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.93 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.78 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.81 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.33 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 100.86 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 5.17 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 40.54 | test_templates.py
test_10_destroy_cpvm | Success | 161.54 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.64 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.60 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.63 | test_ssvm.py
test_06_stop_cpvm | Success | 161.76 | test_ssvm.py
test_05_stop_ssvm | Success | 139.47 | test_ssvm.py
test_04_cpvm_internals | Success | 1.17 | test_ssvm.py
test_03_ssvm_internals | Success | 3.45 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.35 | test_snapshots.py
test_04_change_offering_small | Success | 246.70 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_09_reboot_router | Success | 35.30 | test_routers.py
test_08_start_router | Success | 35.30 | test_routers.py
test_07_stop_router | Success | 10.19 | test_routers.py
test_06_router_advanced | Success | 0.07 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.76 | test_routers.py
test_03_restart_network_cleanup | Success | 75.61 | test_routers.py
test_02_router_internal_adv | Success | 1.03 | test_routers.py
test_01_router_internal_basic | Success | 0.57 | test_routers.py
test_router_dns_guestipquery | Success | 76.70 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.07 | test_router_dns.py
test_router_dhcphosts | Success | 276.76 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.79 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.07 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 161.01 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 5.25 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.45 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 517.17 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 506.65 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 478.51 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 103.44 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 36.02 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.20 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.49 | test_portable_publicip.py
test_isolate_network_password_server | Success | 89.85 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.14 | test_over_provisioning.py
test_oobm_zchange_password | Success | 31.00 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.41 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.27 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 16.02 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 20.57 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.37 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.39 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.35 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 92.79 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.18 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.11 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 0.17 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.13 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 29.52 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.38 | test_non_contigiousvlan.py
test_01_nic | Success | 577.03 | test_nic.py
test_releaseIP | Success | 263.78 | test_network.py
test_reboot_router | Success | 439.52 | test_network.py
test_public_ip_user_account | Success | 10.25 | test_network.py
test_public_ip_admin_account | Success | 40.27 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.91 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.73 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.53 | test_network.py
test_delete_account | Success | 313.94 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.64 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.80 | test_network.py
test_nic_secondaryip_add_remove | Success | 244.27 | test_multipleips_per_nic.py
login_test_saml_user | Success | 24.53 | test_login.py
test_assign_and_removal_lb | Success | 133.39 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.21 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 218.51 | test_loadbalance.py
test_03_list_snapshots | Success | 0.05 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.15 | test_iso.py
test_03_delete_iso | Success | 95.24 | test_iso.py
test_02_edit_iso | Success | 0.06 | test_iso.py
test_01_create_iso | Success | 21.88 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 331.33 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 213.83 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 568.31 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.30 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.16 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 7.02 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 6.85 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 7.00 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 6.93 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 6.90 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 6.94 | test_dynamicroles.py
test_role_lifecycle_update | Success | 11.88 | test_dynamicroles.py
test_role_lifecycle_list | Success | 6.79 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 11.85 | test_dynamicroles.py
test_role_lifecycle_create | Success | 6.89 | test_dynamicroles.py
test_role_inuse_deletion | Success | 6.77 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 8.92 | test_dynamicroles.py
test_role_account_acls | Success | 9.26 | test_dynamicroles.py
test_default_role_deletion | Success | 6.91 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.10 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.84 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 45.77 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 70.70 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.40 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 95.94 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.89 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.86 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 279.05 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 228.43 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 81.06 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #873: CLOUDSTACK-8896: allocated percentage of stora...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r90589240
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1746,10 +1747,10 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool,
allocatedSizeWithTemplate = _capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
}
}
-
- if (volumeVO.getState() != Volume.State.Ready) {
- totalAskingSize += getDataObjectSizeIncludingHypervisorSnapshotReserve(volumeVO, pool);
-
+ // A ready state volume is already allocated in a pool. so the asking size is zero for it.
+ // In case the volume is moving across pools or is not ready yet, the asking size has to be computed
+ s_logger.debug("pool id for the volume with id: " + volumeVO.getId() + " is: " + volumeVO.getPoolId());
--- End diff --
Please wrap this `DEBUG` log in an `if (s_logger.isDebugEnabled)` check to prevent unnecessary/expensive string concatenation when `DEBUG` logging is not enabled.
Minor nit: grammatically, the `:` character after `is` is unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/873
### ACS CI BVT Run
**Sumarry:**
Build Number 105
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=1
Skipped=4
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_nic.py
* test_01_nic Failed
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_ssvm.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@abhinandanprateek @murali-reddy @jburwell this may be useful for 4.9/lts, would you like to review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r41721892
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool)
allocatedSizeWithtemplate = _capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
}
}
- if (volumeVO.getState() != Volume.State.Ready) {
+ // A ready state volume is already allocated in a pool. so the asking size is zero for it.
+ // In case the volume is moving across pools or is not ready yet, the asking size has to be computed
+ s_logger.debug("pool id for the volume with id: " + volumeVO.getId() + " is: " + volumeVO.getPoolId());
--- End diff --
as i said before, looking at the earlier logs will give you the context. what more are you looking for? please suggest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@karuturi can you make suggested changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/873
@rhtyd will do in coming days (though I dont see a reason for the stress on log message leaving aside logic)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
<b>Trillian test result (tid-293)</b>
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38539 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr873-t293-vmware-55u3.zip
Test completed. 46 look ok, 2 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 433.87 | test_privategw_acl.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 424.21 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 822.35 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 725.71 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1557.63 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 817.94 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 707.16 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1457.27 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 25.68 | test_volumes.py
test_06_download_detached_volume | Success | 60.44 | test_volumes.py
test_05_detach_volume | Success | 100.22 | test_volumes.py
test_04_delete_attached_volume | Success | 20.18 | test_volumes.py
test_03_download_attached_volume | Success | 15.26 | test_volumes.py
test_02_attach_volume | Success | 58.71 | test_volumes.py
test_01_create_volume | Success | 525.38 | test_volumes.py
test_03_delete_vm_snapshots | Success | 285.23 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 251.85 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 251.97 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 171.69 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 262.48 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.70 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.19 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 80.77 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.06 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.10 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.09 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.15 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.09 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 266.47 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 20.29 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.09 | test_templates.py
test_01_create_template | Success | 125.69 | test_templates.py
test_10_destroy_cpvm | Success | 236.56 | test_ssvm.py
test_09_destroy_ssvm | Success | 268.30 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.31 | test_ssvm.py
test_07_reboot_ssvm | Success | 158.25 | test_ssvm.py
test_06_stop_cpvm | Success | 176.44 | test_ssvm.py
test_05_stop_ssvm | Success | 178.32 | test_ssvm.py
test_04_cpvm_internals | Success | 1.00 | test_ssvm.py
test_03_ssvm_internals | Success | 3.15 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.07 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.08 | test_ssvm.py
test_01_snapshot_root_disk | Success | 25.94 | test_snapshots.py
test_04_change_offering_small | Success | 97.61 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.02 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.07 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.08 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.11 | test_secondary_storage.py
test_09_reboot_router | Success | 176.07 | test_routers.py
test_08_start_router | Success | 136.00 | test_routers.py
test_07_stop_router | Success | 25.22 | test_routers.py
test_06_router_advanced | Success | 0.04 | test_routers.py
test_05_router_basic | Success | 0.03 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.57 | test_routers.py
test_03_restart_network_cleanup | Success | 180.93 | test_routers.py
test_02_router_internal_adv | Success | 0.86 | test_routers.py
test_01_router_internal_basic | Success | 0.46 | test_routers.py
test_router_dns_guestipquery | Success | 76.81 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.06 | test_router_dns.py
test_router_dhcphosts | Success | 190.50 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.07 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 70.42 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.03 | test_regions.py
test_create_pvlan_network | Success | 5.14 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.27 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 1168.04 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 1031.41 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 212.74 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 36.15 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.15 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.33 | test_portable_publicip.py
test_isolate_network_password_server | Success | 93.81 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.09 | test_over_provisioning.py
test_oobm_zchange_password | Success | 20.51 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.51 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.51 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.52 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.51 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.51 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.52 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.52 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 57.01 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.12 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 0.11 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.06 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.06 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 29.73 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.28 | test_non_contigiousvlan.py
test_01_nic | Success | 695.26 | test_nic.py
test_releaseIP | Success | 342.89 | test_network.py
test_reboot_router | Success | 634.21 | test_network.py
test_public_ip_user_account | Success | 10.19 | test_network.py
test_public_ip_admin_account | Success | 40.19 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 76.36 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.27 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.98 | test_network.py
test_delete_account | Success | 297.66 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.52 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.78 | test_network.py
test_nic_secondaryip_add_remove | Success | 237.53 | test_multipleips_per_nic.py
login_test_saml_user | Success | 21.33 | test_login.py
test_assign_and_removal_lb | Success | 148.13 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 207.01 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 218.61 | test_loadbalance.py
test_03_list_snapshots | Success | 0.04 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.03 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.04 | test_iso.py
test_05_iso_permissions | Success | 0.05 | test_iso.py
test_04_extract_Iso | Success | 5.14 | test_iso.py
test_03_delete_iso | Success | 95.14 | test_iso.py
test_02_edit_iso | Success | 0.03 | test_iso.py
test_01_create_iso | Success | 21.28 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 563.95 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 403.39 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 1087.27 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 887.24 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.18 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.09 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 6.33 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 6.38 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 6.14 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 6.18 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 6.24 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 6.18 | test_dynamicroles.py
test_role_lifecycle_update | Success | 11.31 | test_dynamicroles.py
test_role_lifecycle_list | Success | 6.16 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 11.21 | test_dynamicroles.py
test_role_lifecycle_create | Success | 6.16 | test_dynamicroles.py
test_role_inuse_deletion | Success | 6.15 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 7.51 | test_dynamicroles.py
test_role_account_acls | Success | 7.82 | test_dynamicroles.py
test_default_role_deletion | Success | 6.22 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.05 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.06 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.09 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 105.95 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 50.54 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 221.17 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 25.32 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 165.98 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.13 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.13 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 6.20 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 222.36 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 196.54 | test_affinity_groups.py
test_08_resize_volume | Skipped | 10.22 | test_volumes.py
test_07_resize_fail | Skipped | 10.18 | test_volumes.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.01 | test_staticroles.py
test_01_scale_vm | Skipped | 66.33 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.02 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/873
added ifdebugenabled() checks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r40771703
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool)
allocatedSizeWithtemplate = _capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
}
}
- if (volumeVO.getState() != Volume.State.Ready) {
+ // A ready state volume is already allocated in a pool. so the asking size is zero for it.
+ // In case the volume is moving across pools or is not ready yet, the asking size has to be computed
+ s_logger.debug("pool id for the volume with id: " + volumeVO.getId() + " is: " + volumeVO.getPoolId());
--- End diff --
@karuturi waiting for your reply on wido's question :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/873#issuecomment-216193641
@karuturi please rebase against latest master and push -f, update on status of your PR
LGTM
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #873: CLOUDSTACK-8896: allocated percentage of stora...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
Test LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
LGTM. Travis failure was due to an intermittent issue with oobm test, which has been fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---