You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 22:38:11 UTC
[GitHub] [beam] damccorm opened a new issue, #21302: There should be single source of truth for the project version
damccorm opened a new issue, #21302:
URL: https://github.com/apache/beam/issues/21302
Now the Beam version is defined in two places:
* via the 'version' parameter [in gradle.properties](https://github.com/apache/beam/blob/master/gradle.properties#L27),
* programmatically in the `apply` function [in BeamModulePlugin]([https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L384-L387).]
The latter effectively overrides the former. For someone not very familiar with the Beam build system this may result in a hard to understand and debug behavior: unexpected version gets build and/or pushed to local Maven repository, and changing version in `gradle.properties` does not have any effect.
Adding a comment with a reference to `BeamModulePlugin` to `gradle.properties` can be a good start, and in the long run it would be great to have single source of truth for the project version.
Imported from Jira [BEAM-14051](https://issues.apache.org/jira/browse/BEAM-14051). Original Jira may contain additional context.
Reported by: dmitryor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on issue #21302: There should be single source of truth for the project version
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #21302:
URL: https://github.com/apache/beam/issues/21302#issuecomment-1494426388
Yeah, that should be right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] There should be single source of truth for the project version [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on issue #21302:
URL: https://github.com/apache/beam/issues/21302#issuecomment-1912679793
I got rid of at least one. I think there are probably still a few. I guess I would want to check all the places that https://github.com/apache/beam/blob/master/release/src/main/scripts/set_version.sh sets things. This script may be obsoleted by some new GitHub Actions. (the only purpose the script really has is to know all the places the version exists)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] There should be single source of truth for the project version [beam]
Posted by "Naireen (via GitHub)" <gi...@apache.org>.
Naireen commented on issue #21302:
URL: https://github.com/apache/beam/issues/21302#issuecomment-1912614901
Is this stale? I no longer see the version explicitly mentioned in BeamModulePluginGroovy (seems to have dissapeared between version 2.51 and 2.52.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] zjffdu commented on issue #21302: There should be single source of truth for the project version
Posted by "zjffdu (via GitHub)" <gi...@apache.org>.
zjffdu commented on issue #21302:
URL: https://github.com/apache/beam/issues/21302#issuecomment-1493847298
@damccorm IIUC, if I just want to build a snapshot version on the master branch, I don't need to change anything in `BeamModulePlugin` and `gradle.properties`, is that right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #21302: There should be single source of truth for the project version
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on issue #21302:
URL: https://github.com/apache/beam/issues/21302#issuecomment-1741488860
It is actually defined in 6 places: https://github.com/apache/beam/blob/80311628c27ea68704f46d9f5e6edea6466dfcb3/release/src/main/scripts/set_version.sh#L74
Some of this is "essential" because Go and Python have a different concept for non-release versions than Java does. But I'm at least going to resolve the specific redundancy here which causes spurious `-SNAPSHOT` added when the source of truth should suffice for that determination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #21302: There should be single source of truth for the project version
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on issue #21302:
URL: https://github.com/apache/beam/issues/21302#issuecomment-1741459932
I don't know how I did not know about this. Sheesh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on issue #21302: There should be single source of truth for the project version
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on issue #21302:
URL: https://github.com/apache/beam/issues/21302#issuecomment-1741461209
Is "choose_rc_commit.sh" broken? Answer is "sort of". Yea why in the world does `BeamModulePlugin` do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org