You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/07/30 00:23:17 UTC

[orc] branch main updated: ORC-885: Update bench README.md and allow user env shell (#789)

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new d91e006  ORC-885: Update bench README.md and allow user env shell (#789)
d91e006 is described below

commit d91e006462ce42c7efe122c1a268921824f52fbc
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Thu Jul 29 17:23:10 2021 -0700

    ORC-885: Update bench README.md and allow user env shell (#789)
    
    ### What changes were proposed in this pull request?
    
    This PR aims to update `READM.md` in bench submodule and allow user environment shell in `fetch-data.sh`.
    
    ### Why are the changes needed?
    
    - ORC-821 added `mvnw` in the parent directory.
    - Since ORC-354, `-Pbenchmark` is recommended.
    - In some OS environments, `/bin/bash` is too old to run the script.
    
    ### How was this patch tested?
    
    Pass the CIs.
---
 java/bench/README.md     | 7 +++++--
 java/bench/fetch-data.sh | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/java/bench/README.md b/java/bench/README.md
index b8333ba..a120ae4 100644
--- a/java/bench/README.md
+++ b/java/bench/README.md
@@ -13,9 +13,12 @@ There are three sub-modules to try to mitigate dependency hell:
 * hive - the Hive benchmarks
 * spark - the Spark benchmarks
 
-To build this library:
+To build this library, run the following in the parent directory:
 
-```% ./mvnw clean package```
+```
+% ./mvnw clean package -Pbenchmark
+% cd bench
+```
 
 To fetch the source data:
 
diff --git a/java/bench/fetch-data.sh b/java/bench/fetch-data.sh
index 7f615af..81882f7 100755
--- a/java/bench/fetch-data.sh
+++ b/java/bench/fetch-data.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements.  See the NOTICE file
 # distributed with this work for additional information