I Need Your Feedback on my project proposal

[Xie Xiaodong <xx...@gmail.com>]

Hello, Dear All,
   I have posted my revised proposal on the GSOC site for the project
"Convert current Tomcat valves to Servlet Filters". And I've successfully
build the source code Mark provided, and delved myself into it. I'll add the
deliverables and timescale to this proposal later. Any comments, feedback
and criticism to my proposal are welcomed.


-- 
Sincerely yours and Best Regards,
Xie Xiaodong

Re: I Need Your Feedback on my project proposal

[Xie Xiaodong <xx...@gmail.com>]

Thank you very much for your valuable comments, Mark. I've revised my
proposal according to your comments, and added the deliverables and time
schedule part. Any more comments, feedback and criticism to my proposal are
welcomed.


2009/4/2 Mark Thomas <ma...@apache.org>

> Xie Xiaodong wrote:
> > Hello, Dear All,
> >    I have posted my revised proposal on the GSOC site for the project
> > "Convert current Tomcat valves to Servlet Filters". And I've successfully
> > build the source code Mark provided, and delved myself into it. I'll add
> the
> > deliverables and timescale to this proposal later. Any comments, feedback
> > and criticism to my proposal are welcomed.
>
> GSOC app updated with feedback and repeated here for the archives:
>
> Mark
>
> Good first draft. Things to consider:
>
>   1. Do the StandardEngineValve etc need to be converted to filters? Could
> the
> code in these classes just be moved to the StandardEngine etc?
>   2. For configuration of these filters look at how Tomcat uses a global
> web.xml (in CATALINA_BASE/conf) and think about how this might be extended.
> Take
> a look at how Tomcat does this for global context.xml files, host level
> context.xml files and per context context.xml files
>   3. I think you missed my point about ASync support. The question wasn't
> how/if Tomcat provides the threads to process these requests. The question
> is
> what needs to be done to make the filters compatible with ASync support and
> are
> there any valves where ASync support may cause issues. Think about the
> AccessLogValve
>
>
-- 
Sincerely yours and Best Regards,
Xie Xiaodong

Re: I Need Your Feedback on my project proposal

[Mark Thomas <ma...@apache.org>]

Xie Xiaodong wrote:
> Hello, Dear All,
>    I have posted my revised proposal on the GSOC site for the project
> "Convert current Tomcat valves to Servlet Filters". And I've successfully
> build the source code Mark provided, and delved myself into it. I'll add the
> deliverables and timescale to this proposal later. Any comments, feedback
> and criticism to my proposal are welcomed.

GSOC app updated with feedback and repeated here for the archives:

Mark

Good first draft. Things to consider:

   1. Do the StandardEngineValve etc need to be converted to filters? Could the
code in these classes just be moved to the StandardEngine etc?
   2. For configuration of these filters look at how Tomcat uses a global
web.xml (in CATALINA_BASE/conf) and think about how this might be extended. Take
a look at how Tomcat does this for global context.xml files, host level
context.xml files and per context context.xml files
   3. I think you missed my point about ASync support. The question wasn't
how/if Tomcat provides the threads to process these requests. The question is
what needs to be done to make the filters compatible with ASync support and are
there any valves where ASync support may cause issues. Think about the
AccessLogValve




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org