You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tzolov <gi...@git.apache.org> on 2015/08/04 14:31:51 UTC

[GitHub] incubator-zeppelin pull request: ZEPPELIN-196: fix the auto-comple...

GitHub user tzolov opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/180

    ZEPPELIN-196: fix the auto-completion issue

    The existing code  ($rootScope.$emit('sendNewEvent',...)) emits events to the  "sendNewEvent" channel but apparently there are no listener listening to it! 
    
    The websocketMsgSrv service exposes a completion() method that is not used. The WS communication goes through this webscket service so it seemed natural to use it for the completion method as well. 
    
    This change fixes the event flow problem. You can trace that COMPLETION events go down to the Interceptor's compete method and back to the completers $scope.$on('completionList') handler. 
    
    It seems though that the SparkInteprteer's completer doesn't work. It never returns completion suggestions. But this is would be a different issue. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzolov/incubator-zeppelin ZEPPELIN-196

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #180
    
----
commit d272ec82fd8aa9155c3e115fda89113833d2d4e7
Author: tzolov <ch...@gmail.com>
Date:   2015-08-04T12:19:53Z

    ZEPPELIN-196: fix the autocompletion issue

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-196: fix the auto-comple...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/180#issuecomment-127781157
  
    looks good, good explanations


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-196: fix the auto-comple...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/180#issuecomment-128524780
  
    @tzolov Thanks for the fix. just merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-196: fix the auto-comple...

Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/180#issuecomment-127595901
  
    Note that if the Interpreter has not not been loaded yet the response for the first Ctrl+. will be delayed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-196: fix the auto-comple...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/180


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-196: fix the auto-comple...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/180#issuecomment-127775960
  
    Thanks for the fix. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-196: fix the auto-comple...

Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/180#issuecomment-128528441
  
    Excellent! Thanks guys!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-196: fix the auto-comple...

Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/180#issuecomment-128521622
  
    @Leemoonsoo, @bzz, @felixcheung is there anything else I need to do before this PR can be merged?
    This issue along with [ZEPPELIN-141](https://github.com/apache/incubator-zeppelin/pull/181) are blocking the work of implementing PSQL and Geode completers and fixing the Spark completer. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---