You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/11 19:41:00 UTC
[jira] [Commented] (KAFKA-7498)
common.requests.CreatePartitionsRequest uses clients.admin.NewPartitions
[ https://issues.apache.org/jira/browse/KAFKA-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646962#comment-16646962 ]
ASF GitHub Bot commented on KAFKA-7498:
---------------------------------------
rajinisivaram opened a new pull request #5784: KAFKA-7498: Remove references from `common.requests` to `clients`
URL: https://github.com/apache/kafka/pull/5784
Add `CreatePartitionsRequest.PartitionDetails` similar to `CreateTopicsRequest.TopicDetails` to avoid references from `common.requests` to `clients`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> common.requests.CreatePartitionsRequest uses clients.admin.NewPartitions
> ------------------------------------------------------------------------
>
> Key: KAFKA-7498
> URL: https://issues.apache.org/jira/browse/KAFKA-7498
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Reporter: Rajini Sivaram
> Assignee: Rajini Sivaram
> Priority: Major
> Fix For: 2.1.0
>
>
> `org.apache.kafka.common.requests.CreatePartitionsRequest` currently uses `org.apache.kafka.clients.admin.NewPartitions`. We shouldn't have references from `common` to `clients`. Since `org.apache.kafka.clients.admin` is a public package, we cannot use a common class for Admin API and requests. So we should do something similar to CreateTopicsRequest for which we have `org.apache.kafka.clients.admin.NewTopic` class used for the admin API and an equivalent `org.apache.kafka.common.requests.CreateTopicsRequest.TopicDetails` class that doesn't refer to `clients.admin`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)