You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/07/12 20:37:33 UTC

Re: Review Request 70907: Added recovery of agent drain information.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70907/#review216569
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On June 28, 2019, 2:27 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70907/
> -----------------------------------------------------------
> 
> (Updated June 28, 2019, 2:27 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9822
>     https://issues.apache.org/jira/browse/MESOS-9822
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With this patch the agent will, after executor reregistration finished,
> replay any active drain information so remaining tasks are drained as
> well. We need to wait until executors had a chance to register so they
> are not terminated should we try to send kill task request before the
> executor has registered.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
>   src/slave/state.hpp 45836e5805a5038c0b3b5563ea995c3fa90ab808 
>   src/slave/state.cpp e0a850e03fb0d726bf7b02bbd6b298d81afae399 
>   src/tests/slave_tests.cpp 7ba2df9fef9966cd09e0af3f4ef3bb260b6167f6 
> 
> 
> Diff: https://reviews.apache.org/r/70907/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>