You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/29 17:59:58 UTC

[GitHub] [spark] amaliujia commented on pull request #38801: [SPARK-41317][CONNECT][PYTHON] Add basic support for DataFrameWriter

amaliujia commented on PR #38801:
URL: https://github.com/apache/spark/pull/38801#issuecomment-1331078267

   Overall look good to me.
   
   This is based on the past scala and proto side writer API work so no big concerns. 
   
   IIRC there were still some proto API level design comments that worth to take a look. I probably could re-visit that later after expression work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org