You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/15 10:40:54 UTC
[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request
#5201: Update documents of orchestration for 5.x
menghaoranss opened a new pull request #5201: Update documents of orchestration for 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/5201
Changes proposed in this pull request:
- /User Manual/Sharding-JDBC/Configuration manual, update orchestration configuration demo and explanation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking merged pull request #5201:
Update documents of orchestration for 5.x
Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #5201: Update documents of orchestration for 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/5201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #5201:
Update documents of orchestration for 5.x
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #5201: Update documents of orchestration for 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/5201#issuecomment-615100514
> After verify this config, plz let me know, I will merge it.
I have verified in examples, and anther PR has been commited to fix the problem about metadata with sharding-jdbc. The configurations in the document are work well now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #5201: Update documents of orchestration for 5.x
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5201: Update documents of orchestration for 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/5201#discussion_r408783728
##########
File path: docs/document/content/manual/sharding-jdbc/configuration/config-spring-boot.cn.md
##########
@@ -233,11 +233,11 @@ spring.shardingsphere.sharding.tables.t_order_item.key-generator.column=order_it
spring.shardingsphere.sharding.binding-tables=t_order,t_order_item
spring.shardingsphere.sharding.broadcast-tables=t_config
-spring.shardingsphere.orchestration.name=spring_boot_ds_sharding
-spring.shardingsphere.orchestration.overwrite=true
-spring.shardingsphere.orchestration.registry.type=zookeeper
-spring.shardingsphere.orchestration.registry.namespace=orchestration-spring-boot-sharding-test
-spring.shardingsphere.orchestration.registry.server-lists=localhost:2181
+spring.shardingsphere.orchestration.spring_boot_ds_sharding.orchestration-type=registry_center,config_center,metadata_center
Review comment:
There params should be verified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #5201:
Update documents of orchestration for 5.x
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5201: Update documents of orchestration for 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/5201#issuecomment-614559272
After verify this config, plz let me know, I will merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5201:
Update documents of orchestration for 5.x
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5201: Update documents of orchestration for 5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/5201#issuecomment-613997716
## Pull Request Test Coverage Report for [Build 11075](https://coveralls.io/builds/30090352)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.167%**
---
| Totals | [](https://coveralls.io/builds/30090352) |
| :-- | --: |
| Change from base [Build 11016](https://coveralls.io/builds/30045669): | 0.0% |
| Covered Lines: | 11709 |
| Relevant Lines: | 20482 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services