[jira] [Comment Edited] (SOLR-14824) Simplify set of Ref Guide build parameters

["Uwe Schindler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197265#comment-17197265 ] 

Uwe Schindler edited comment on SOLR-14824 at 9/16/20, 10:34 PM:
-----------------------------------------------------------------

Hi Hoss,

looks fine to me in general, but I'd change a bit those crazy settings: 

{{solrRootPath: '../../../../solr/',}}

This is a bit strange to read, it would be much cleaner to use gradle's ability to know where the files are without relying on the project directory layout, like {{project(':solr').projectDir}}

The same applies to the "localJavadocs" folders (see SOLR-14870).


was (Author: thetaphi):
Hi Hoss,

looks fine to me in general, but I'd change a bit those crazy settings: 

{{solrRootPath: '../../../../solr/',}}

This is a bit strange to read, it would be much cleaner to use gradle's ability to know where the files are without relying on the project directory layout, like {{$project(':solr').projectDir}}

The same applies to the "localJavadocs" folders (see SOLR-14870).

> Simplify set of Ref Guide build parameters
> ------------------------------------------
>
>                 Key: SOLR-14824
>                 URL: https://issues.apache.org/jira/browse/SOLR-14824
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Build, documentation
>            Reporter: Cassandra Targett
>            Assignee: Chris M. Hostetter
>            Priority: Minor
>         Attachments: SOLR-14824.patch, SOLR-14824.patch
>
>
> While trying to solve LUCENE-9495, I thought it might be a good idea to try to simplify the set of variables and properties used during the Ref Guide build.
> There are 3 areas to work on:
> 1. Remove the "barebones-html" build. With Gradle the build is self-contained and {{gradlew check}} and {{gradle precommit}} could just build the full docs and check them.
> 2. Remove some properties that only existed for a hypothetical need related to the now-removed PDF.
> 3. Change remaining properties to be defined directly in build.gradle instead of relying on ant properties functionality.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org