You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "jmuehlner (via GitHub)" <gi...@apache.org> on 2023/05/11 00:17:54 UTC

[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #862: GUACAMOLE-926: Fix SQL Server JDBC auth extension by disabling batch executor.

jmuehlner commented on code in PR #862:
URL: https://github.com/apache/guacamole-client/pull/862#discussion_r1190493677


##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/conf/SQLServerEnvironment.java:
##########
@@ -295,4 +295,36 @@ public boolean enforceAccessWindowsForActiveSessions() throws GuacamoleException
                 true);
     }
 
+    @Override
+    public boolean shouldUseBatchExecutor() {

Review Comment:
   This change isn't required to fix the problem with the batch executor, but it is awfully handy for testing using self-hosted SQL Server instances with self-signed certificates.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org