You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/30 18:22:45 UTC
[GitHub] [arrow] aarashy opened a new issue, #14791: [Javascript] `tableToIPC` has off-by-one errors in the generated IPC byte length
aarashy opened a new issue, #14791:
URL: https://github.com/apache/arrow/issues/14791
### Describe the bug, including details regarding any error messages, version, and platform.
Hello, I filed an issue with `arrow-rs` because panics were being triggered in their IPC byte parsing functions.
https://github.com/apache/arrow-rs/issues/3215#issuecomment-1331649397
The input IPC bytes were the result of `tableToIPC`. According to the info I've gathered in my other issue, it seems like `tableToIPC` is not correctly padding and instead incorrectly truncating bits in cases where the length of a record batch is not divisible by 8.
For example, the Null Bit Buffer encodes whether each row is null or not using 1 bit. My record batch has length 518, which is not divisible by 8 (64.75). Some parsing/validation inside arrow-rs is therefore expecting the null bit buffer to be 65 bytes long, but it's only 64 bytes long.
### Component(s)
Format, Integration, JavaScript
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz closed issue #14791: [Javascript] `tableToIPC` has off-by-one errors in the generated IPC byte length
Posted by GitBox <gi...@apache.org>.
domoritz closed issue #14791: [Javascript] `tableToIPC` has off-by-one errors in the generated IPC byte length
URL: https://github.com/apache/arrow/issues/14791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] aarashy commented on issue #14791: [Javascript] `tableToIPC` has off-by-one errors in the generated IPC byte length
Posted by GitBox <gi...@apache.org>.
aarashy commented on issue #14791:
URL: https://github.com/apache/arrow/issues/14791#issuecomment-1340116167
@trxcllnt - Hello! You seem to be the biggest contributor to this file https://github.com/apache/arrow/blob/5611f2bd0d6136b005d137a84b50709fc5c813bb/js/src/ipc/writer.ts
I wonder if you have any insight on what might have been happening here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] trxcllnt commented on issue #14791: [Javascript] `tableToIPC` has off-by-one errors in the generated IPC byte length
Posted by GitBox <gi...@apache.org>.
trxcllnt commented on issue #14791:
URL: https://github.com/apache/arrow/issues/14791#issuecomment-1341355959
@aarashy thanks for the report, I'll take a look and try to repro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org