[GitHub] [tvm] tqchen commented on a change in pull request #9394: [docs][bug] Add redirects for moved pages

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #9394:
URL: https://github.com/apache/tvm/pull/9394#discussion_r739311950



##########
File path: docs/conf.py
##########
@@ -467,5 +467,26 @@ def process_docstring(app, what, name, obj, options, lines):
         update_alias_docstring(name, obj, lines)
 
 
+from string import Template
+import json
+
+
+def build_redirects(app, docname):  # Sphinx expects two arguments

Review comment:
       build_legacy_redirect

##########
File path: docs/redirects.data
##########
@@ -0,0 +1,272 @@
+[

Review comment:
       how about we leave it as part of pyfile(both to keep things simpler and get around the filetype check, alternatively, rename to .json), the type check do not like json, we can simply embed into the conf.py or legacy_redirect.py.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org