[GitHub] [couchdb] jaydoane commented on a change in pull request #3312: Import weatherreport

[GitBox <gi...@apache.org>]

jaydoane commented on a change in pull request #3312:
URL: https://github.com/apache/couchdb/pull/3312#discussion_r555509159



##########
File path: src/ioq/src/ioq.erl
##########
@@ -50,6 +51,9 @@ call(Fd, Msg, Metadata) ->
             queued_call(Fd, Msg, Priority)
     end.
 
+get_queue_lengths() ->
+    gen_server:call(?MODULE, get_queue_lengths).

Review comment:
       Not sure, but I had to modify this IOQ lib here because `weatherreport` previously got [something like this](https://github.com/apache/couchdb-ioq/blob/main/src/ioq.erl#L56) from the old Cloudant IOQ library, and this seemed like the closest analogy to that metric. You can see later in this file that there's a compatibility clause that depends on the result of `erlang:function_exported(ioq, get_queue_lengths, 0)`.  But this is basically a newly exposed stat for this IOQ lib, and I have no idea how useful it might end up being in practice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org