[jira] [Commented] (SPARK-39658) Reconsider exposure of Json4s symbols in public ResourceInformation.toJson API

["Yang Jie (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-39658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619964#comment-17619964 ] 

Yang Jie commented on SPARK-39658:
----------------------------------

Do we have any clear conclusions or plans for this issue?

 

> Reconsider exposure of Json4s symbols in public ResourceInformation.toJson API
> ------------------------------------------------------------------------------
>
>                 Key: SPARK-39658
>                 URL: https://issues.apache.org/jira/browse/SPARK-39658
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 3.0.0
>            Reporter: Josh Rosen
>            Priority: Major
>
> Followup to discussion at [https://github.com/apache/spark/pull/36885#discussion_r898644147]
> Spark's `ResourceInformation` class exposes Json4s symbols in its public API (via the toJson method). 
> In the long run, I don't think that exposing third-party library symbols in our public APIs is a good idea. Perhaps we should make this API private or change it to require that users / implementors return an object which can be turned to JSON via Jackson ObjectMapper.
> In principle we still have some freedom to change this because the ResourceInformation class is marked as `@Evolving`
> I'm filing this ticket so that I can reference it in TODO code comments.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org