You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by radarwave <gi...@git.apache.org> on 2016/04/19 05:33:59 UTC
[GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
GitHub user radarwave opened a pull request:
https://github.com/apache/incubator-hawq/pull/622
HAWQ-668. hawq check should be able to check yarn settings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radarwave/incubator-hawq HAWQ-668
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/622.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #622
----
commit 8a4046ad98337cd62bb603f463399288d27ba9fb
Author: rlei <rl...@pivotal.io>
Date: 2016-04-13T09:13:02Z
HAWQ-668. hawq check should be able to check yarn settings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/622
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the pull request:
https://github.com/apache/incubator-hawq/pull/622#issuecomment-211732203
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/622#discussion_r60174348
--- Diff: tools/bin/gpcheck ---
@@ -567,7 +683,7 @@ def testHAWQ(host):
return
# check HAWQ master's memory size
- expected_vmemory_size = 1024
+ expected_vmemory_size = 8192
--- End diff --
do we want to check exact value, or minimal value ? in other words, should it be guc_vmemsize_master < expected_vmemory_size rather than guc_vmemsize_master != expected_vmemory_size in the statement below and other similar comparisons ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
Posted by ztao1987 <gi...@git.apache.org>.
Github user ztao1987 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/622#discussion_r60178640
--- Diff: src/backend/utils/misc/etc/gpcheck.cnf ---
@@ -54,5 +54,60 @@ dfs.namenode.handler.count = 60
ipc.server.handler.queue.size = 3300
dfs.datanode.handler.count = 60
ipc.client.connection.maxidletime = 3600000
-dfs.namenode.accesstime.precision = -1
+dfs.namenode.accesstime.precision = 0
+dfs.client.read.shortcircuit = true
+[hdfs.non]
+hdfs.non = none
+dfs.block.access.token.enable = FALSE
+
+[hdfs.ha]
+hdfs.ha = none
+dfs.block.access.token.enable = FALSE
+
+[hdfs.kerberos]
+hdfs.kerberos = none
+dfs.block.access.token.enable = TRUE
+dfs.datanode.data.dir.perm = 750
--- End diff --
For non-kerberos, it should be 700
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/622#discussion_r60184658
--- Diff: src/backend/utils/misc/etc/gpcheck.cnf ---
@@ -54,5 +54,60 @@ dfs.namenode.handler.count = 60
ipc.server.handler.queue.size = 3300
dfs.datanode.handler.count = 60
ipc.client.connection.maxidletime = 3600000
-dfs.namenode.accesstime.precision = -1
+dfs.namenode.accesstime.precision = 0
+dfs.client.read.shortcircuit = true
+[hdfs.non]
+hdfs.non = none
+dfs.block.access.token.enable = FALSE
+
+[hdfs.ha]
+hdfs.ha = none
+dfs.block.access.token.enable = FALSE
+
+[hdfs.kerberos]
+hdfs.kerberos = none
+dfs.block.access.token.enable = TRUE
+dfs.datanode.data.dir.perm = 750
--- End diff --
Since 700 is default values and user might have something like '755', we do not check for non-kerberos mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/622#issuecomment-211822250
＋1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-668. hawq check should be able t...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/622#discussion_r60184397
--- Diff: tools/bin/gpcheck ---
@@ -567,7 +683,7 @@ def testHAWQ(host):
return
# check HAWQ master's memory size
- expected_vmemory_size = 1024
+ expected_vmemory_size = 8192
--- End diff --
If user set the value too big, like set it as '81920' by mistake, 'hawq check' won't give a warning since it's bigger than the expect values.
So I think we can keep current way. User will decide wether to fix a hawq check warning base on the document and their environment.
If any new requirement, we can change it in another jira. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---