You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2015/06/09 16:19:00 UTC
svn commit: r1684435 [6/9] - /myfaces/site/publish/tobago/
Modified: myfaces/site/publish/tobago/pmd.html
URL: http://svn.apache.org/viewvc/myfaces/site/publish/tobago/pmd.html?rev=1684435&r1=1684434&r2=1684435&view=diff
==============================================================================
--- myfaces/site/publish/tobago/pmd.html (original)
+++ myfaces/site/publish/tobago/pmd.html Tue Jun 9 14:18:59 2015
@@ -14,7 +14,7 @@
<div class="date">
- Last Published: 23 Mar 2015
+ Last Published: 09 Jun 2015
</div>
<ul>
<li>
@@ -171,11 +171,11 @@
<ul>
<li class="none">
- <a href="cpd.html">CPD Report</a>
+ <a href="cpd.html">CPD</a>
</li>
<li class="none">
- <a href="pmd.html" class="selected">PMD Report</a>
+ <a href="pmd.html" class="selected">PMD</a>
</li>
<li class="none">
@@ -281,67 +281,11 @@
<h2>PMD Results<a name="PMD_Results"></a></h2>
<p>The following document contains the results of <a class="externalLink"
- href="http://pmd.sourceforge.net/">PMD</a> 5.0.2.</p></div>
+ href="http://pmd.sourceforge.net/">PMD</a> 5.2.3.</p></div>
<div class="section">
<h2>Files<a name="Files"></a></h2>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/ajax/AjaxUtils.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoajaxAjaxUtils.java"></a></h3>
- <table border="0" class="bodyTable">
- <tr class="a">
- <th>Violation</th>
- <th>Line</th>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#49">49</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#49">49</a></td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#54">54</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#61">61</a></td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#66">66</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#66">66</a></td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#76">76</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#81">81</a></td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#82">82</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#112">112</a> - <a
- href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#113">113</a></td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#112">112</a> - <a
- href="./xref/org/apache/myfaces/tobago/ajax/AjaxUtils.html#113">113</a></td>
- </tr>
- </table>
- </div>
- <div class="section">
<h3>Tobago Core - org/apache/myfaces/tobago/application/ActionListenerImpl.java<a
name="Tobago_Core_-_orgapachemyfacestobagoapplicationActionListenerImpl.java"></a></h3>
<table border="0" class="bodyTable">
@@ -352,38075 +296,7660 @@
<tr class="b">
<td>Private field 'base' could be made final; it is only initialized in the declaration or constructor.
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#41">41</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L45">45</a></td>
</tr>
<tr class="a">
<td>An instanceof check is being performed on the caught exception. Create a separate catch clause for
this exception type.
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#53">53</a></td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#59">59</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#62">62</a></td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#64">64</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#65">65</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L57">57</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#65">65</a></td>
+ <td>Local variable 'errorLogMsg' could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L67">67</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#66">66</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L68">68</a>–<a
+ href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L74">74</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#70">70</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#L82">82</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/compat/FacesUtilsEL.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocompatFacesUtilsEL.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#71">71</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#73">73</a></td>
+ <td>This class has too many methods, consider refactoring it.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L48">48</a>–<a
+ href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L268">268</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#75">75</a></td>
+ <td>These nested if statements could be combined</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L72">72</a>–<a
+ href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L74">74</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#75">75</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L206">206</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#76">76</a></td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/ActionListenerImpl.html#78">78</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L216">216</a>–<a
+ href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#L221">221</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoapplicationLabelValueExpressionFacesMessage.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/component/Facets.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocomponentFacets.java"></a></h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#47">47</a>
- - <a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#48">48</a>
- </td>
- </tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#47">47</a>
- - <a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#48">48</a>
+ <td>Fields should be declared at the top of the class, before any method declarations, constructors,
+ initializers or inner classes.
</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Facets.html#L55">55</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocomponentMethodBindingToMethodExpression.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#47">47</a>
- - <a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#48">48</a>
- </td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#47">47</a>
- - <a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#48">48</a>
+ <td>This class has too many methods, consider refactoring it.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L37">37</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L231">231</a>
</td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#48">48</a>
- </td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L47">47</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L48">48</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#49">49</a>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L93">93</a>
</td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocomponentMethodExpressionToMethodBinding.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#49">49</a>
- </td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#55">55</a>
- - <a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#56">56</a>
+ <td>Avoid using redundant field initializer for 'isTransient'</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L38">38</a>
</td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#55">55</a>
- - <a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#56">56</a>
- </td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#55">55</a>
- - <a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#56">56</a>
+ <td>Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing
+ import 'javax.faces.el.MethodNotFoundException'
</td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#55">55</a>
- - <a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#56">56</a>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L62">62</a>
</td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#56">56</a>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L68">68</a>
</td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#57">57</a>
+ <td>Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing
+ import 'javax.faces.el.MethodNotFoundException'
</td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.html#57">57</a>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L74">74</a>
</td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/compat/FacesUtilsEL.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocompatFacesUtilsEL.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/component/Sorter.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocomponentSorter.java"></a></h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
- <td>This class has too many methods, consider refactoring it.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#48">48</a> - <a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#268">268</a></td>
- </tr>
<tr class="b">
- <td>Useless parentheses.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#71">71</a></td>
+ <td>Possible God class (WMC=51, ATFD=25, TCC=0.2)</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L20">20</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L259">259</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#71">71</a></td>
+ <td>The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 30).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L49">49</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
<tr class="b">
- <td>These nested if statements could be combined</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#72">72</a> - <a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#74">74</a></td>
+ <td>The class 'Sorter' has a Modified Cyclomatic Complexity of 6 (Highest = 28).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L49">49</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#90">90</a></td>
+ <td>The class 'Sorter' has a Standard Cyclomatic Complexity of 6 (Highest = 28).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L49">49</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#135">135</a></td>
+ <td>The method perform() has an NPath complexity of 139872</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#145">145</a></td>
+ <td>The method 'perform' has a Cyclomatic Complexity of 30.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#150">150</a></td>
+ <td>Avoid really long methods.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#157">157</a></td>
+ <td>The method 'perform' has a Modified Cyclomatic Complexity of 28.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#165">165</a></td>
+ <td>The method 'perform' has a Standard Cyclomatic Complexity of 28.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#180">180</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L96">96</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L137">137</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#180">180</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L99">99</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L132">132</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#180">180</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L199">199</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#195">195</a></td>
+ <td>The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L224">224</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L249">249</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/component/SupportsRenderedPartially.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocomponentSupportsRenderedPartially.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#195">195</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#196">196</a></td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/SupportsRenderedPartially.html#L27">27</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/ClientProperties.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextClientProperties.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#196">196</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#206">206</a></td>
+ <td>Use equals() to compare object references.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#L204">204</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/Markup.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextMarkup.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#206">206</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#206">206</a></td>
+ <td>This class has too many methods, consider refactoring it.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L50">50</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L317">317</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#206">206</a></td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L96">96</a></td>
</tr>
<tr class="b">
- <td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#216">216</a> - <a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#221">221</a></td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L106">106</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#216">216</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L166">166</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#217">217</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L178">178</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#219">219</a> - <a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#220">220</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L179">179</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#219">219</a> - <a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#220">220</a></td>
+ <td>Use equals() to compare object references.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L201">201</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#219">219</a> - <a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#220">220</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L204">204</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L215">215</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#219">219</a> - <a
- href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#220">220</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/compat/FacesUtilsEL.html#220">220</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L245">245</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L254">254</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/Facets.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentFacets.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/MarkupConfig.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextMarkupConfig.java"></a></h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
- <td>Fields should be declared at the top of the class, before any method declarations, constructors,
- initializers or inner classes.
+ <tr class="b">
+ <td>Private field 'markups' could be made final; it is only initialized in the declaration or
+ constructor.
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Facets.html#55">55</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/MarkupConfig.html#L30">30</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentMethodBindingToMethodExpression.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/ResourceManagerUtils.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextResourceManagerUtils.java"></a></h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
- <td>This class has too many methods, consider refactoring it.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#37">37</a> -
- <a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#231">231</a>
- </td>
- </tr>
<tr class="b">
- <td>Document empty constructor</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#47">47</a> -
- <a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#48">48</a></td>
- </tr>
- <tr class="a">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#93">93</a>
- </td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#112">112</a>
- </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L154">154</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#112">112</a>
- </td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#112">112</a>
- </td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#123">123</a>
- </td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L166">166</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#124">124</a>
- </td>
+ <td>This call to String.startsWith can be rewritten using String.charAt(0)</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L233">233</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#139">139</a>
- </td>
+ <td>Local variable 'dot' could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L243">243</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#139">139</a>
- </td>
+ <td>Local variable 'slash' could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ResourceManagerUtils.html#L247">247</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/ThemeImpl.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextThemeImpl.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#139">139</a>
- </td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#139">139</a>
- </td>
+ <td>Possible God class (WMC=51, ATFD=16, TCC=0.06436781609195402)</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L20">20</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L276">276</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#140">140</a>
- </td>
+ <td>Too many fields</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L276">276</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#140">140</a>
+ <td>Private field 'productionResources' could be made final; it is only initialized in the declaration or
+ constructor.
</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L46">46</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#215">215</a>
+ <td>Private field 'resources' could be made final; it is only initialized in the declaration or
+ constructor.
</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L47">47</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#215">215</a>
- </td>
+ <td>Avoid using redundant field initializer for 'unmodifiable'</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L55">55</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#215">215</a>
- </td>
+ <td>Deeply nested if..then statements are hard to read</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L151">151</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L156">156</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#218">218</a>
+ <td>StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L180">180</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#218">218</a>
- </td>
+ <td>Avoid appending characters as strings in StringBuffer.append.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L183">183</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#218">218</a>
- </td>
+ <td>Avoid appending characters as strings in StringBuffer.append.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L186">186</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentMethodExpressionToMethodBinding.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/ThemeResource.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextThemeResource.java"></a></h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>Avoid using redundant field initializer for 'isTransient'</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#38">38</a>
- </td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResource.html#L50">50</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#60">60</a>
- </td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResource.html#L56">56</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/ThemeResources.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextThemeResources.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="b">
- <td>Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing
- import 'javax.faces.el.MethodNotFoundException'
- </td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#62">62</a>
- </td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="a">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#68">68</a>
+ <td>Private field 'scriptList' could be made final; it is only initialized in the declaration or
+ constructor.
</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L34">34</a></td>
</tr>
<tr class="b">
- <td>Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing
- import 'javax.faces.el.MethodNotFoundException'
- </td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#74">74</a>
+ <td>Private field 'styleList' could be made final; it is only initialized in the declaration or
+ constructor.
</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/ThemeResources.html#L35">35</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/Sorter.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentSorter.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/TobagoBundle.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextTobagoBundle.java"></a></h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>Possible God class (WMC=51, ATFD=25, TCC=0.2)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#49">49</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#258">258</a></td>
+ <td>Private field 'bundleName' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/TobagoBundle.html#L41">41</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/TransientStateHolder.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextTransientStateHolder.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 30).</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#49">49</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#258">258</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Avoid really long methods.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#64">64</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#201">201</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/TransientStateHolder.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/TransientStateHolder.html#L34">34</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/context/UserAgent.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagocontextUserAgent.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>The method perform() has an NPath complexity of 139872</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#64">64</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#201">201</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>The method 'perform' has a Cyclomatic Complexity of 30.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#64">64</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#201">201</a></td>
+ <td>The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L386">386</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#68">68</a></td>
+ <td>The class 'UserAgent' has a Standard Cyclomatic Complexity of 3 (Highest = 19).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L386">386</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#73">73</a></td>
+ <td>The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L386">386</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#95">95</a></td>
+ <td>The String literal "msie" appears 12 times in this file; the first occurrence is on line
+ 43
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L43">43</a></td>
</tr>
<tr class="b">
- <td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#96">96</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#137">137</a></td>
+ <td>The String literal "opera" appears 4 times in this file; the first occurrence is on line
+ 107
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L107">107</a></td>
</tr>
<tr class="a">
- <td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#99">99</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#132">132</a></td>
+ <td>The String literal "mozilla" appears 4 times in this file; the first occurrence is on line
+ 131
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L131">131</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#99">99</a></td>
+ <td>The String literal "gecko" appears 5 times in this file; the first occurrence is on line
+ 154
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L154">154</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#106">106</a></td>
+ <td>The method 'getInstance' has a Cyclomatic Complexity of 20.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L275">275</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L330">330</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#106">106</a></td>
+ <td>The method 'getInstance' has a Standard Cyclomatic Complexity of 19.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L275">275</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L330">330</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#108">108</a></td>
+ <td>The method 'getInstance' has a Modified Cyclomatic Complexity of 19.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L275">275</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L330">330</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#109">109</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L346">346</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L348">348</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#111">111</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#112">112</a></td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L360">360</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#112">112</a></td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L378">378</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/convert/DurationConverter.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoconvertDurationConverter.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#114">114</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#114">114</a></td>
+ <td>The class 'DurationConverter' has a Cyclomatic Complexity of 8 (Highest = 10).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L37">37</a>–<a
+ href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L150">150</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#117">117</a></td>
+ <td>The class 'DurationConverter' has a Modified Cyclomatic Complexity of 7 (Highest = 10).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L37">37</a>–<a
+ href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L150">150</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#124">124</a></td>
+ <td>The class 'DurationConverter' has a Standard Cyclomatic Complexity of 8 (Highest = 10).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L37">37</a>–<a
+ href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L150">150</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#125">125</a></td>
+ <td>Unnecessary wrapper object creation</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L67">67</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#139">139</a></td>
+ <td>Avoid declaring a variable if it is unreferenced before a possible exit point.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L90">90</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#153">153</a></td>
+ <td>The method 'getUnitFactor' has a Cyclomatic Complexity of 10.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L121">121</a>–<a
+ href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L148">148</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#153">153</a></td>
+ <td>The method 'getUnitFactor' has a Modified Cyclomatic Complexity of 10.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L121">121</a>–<a
+ href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L148">148</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#154">154</a></td>
+ <td>The method 'getUnitFactor' has a Standard Cyclomatic Complexity of 10.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L121">121</a>–<a
+ href="./xref/org/apache/myfaces/tobago/convert/DurationConverter.html#L148">148</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/el/ConstantMethodBinding.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoelConstantMethodBinding.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#154">154</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#156">156</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodBinding.html#L38">38</a>–<a
+ href="./xref/org/apache/myfaces/tobago/el/ConstantMethodBinding.html#L39">39</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#158">158</a></td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodBinding.html#L41">41</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/el/UserWrapper.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoelUserWrapper.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#162">162</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#175">175</a></td>
+ <td>Private field 'roles' could be made final; it is only initialized in the declaration or constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/UserWrapper.html#L35">35</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/FacesEventWrapper.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventFacesEventWrapper.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#175">175</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#179">179</a></td>
+ <td>Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/FacesEventWrapper.html#L31">31</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionStateChangeListener.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#180">180</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#192">192</a></td>
+ <td>Avoid using redundant field initializer for 'isTransient'</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L33">33</a>
+ </td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#192">192</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L35">35</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L36">36</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTabChangeListener.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#198">198</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#199">199</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="a">
- <td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#199">199</a></td>
+ <td>Avoid using redundant field initializer for 'isTransient'</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L33">33</a>
+ </td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#199">199</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L35">35</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L36">36</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeExpansionListener.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#199">199</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#199">199</a></td>
+ <td>Avoid using redundant field initializer for 'isTransient'</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L34">34</a>
+ </td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#221">221</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L36">36</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L37">37</a>
+ </td>
</tr>
<tr class="b">
- <td>The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#224">224</a> - <a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#249">249</a></td>
+ <td>Avoid unused private methods such as 'elContext()'.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L47">47</a>
+ </td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeMarkedListener.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#232">232</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Useless parentheses.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#232">232</a></td>
+ <td>Avoid using redundant field initializer for 'isTransient'</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.html#L37">37</a>
+ </td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#232">232</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.html#L39">39</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.html#L40">40</a></td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#232">232</a></td>
+ <td>Avoid unused private methods such as 'elContext()'.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.html#L50">50</a>
+ </td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeSelectedListener.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#233">233</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (static property access)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#233">233</a></td>
+ <td>Avoid using redundant field initializer for 'isTransient'</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L33">33</a>
+ </td>
</tr>
<tr class="a">
- <td>Useless parentheses.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#233">233</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L35">35</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L36">36</a>
+ </td>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#242">242</a></td>
+ <td>Avoid unused private methods such as 'elContext()'.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L46">46</a>
+ </td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/SupportsRenderedPartially.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentSupportsRenderedPartially.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/PageAction.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventPageAction.java"></a></h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/SupportsRenderedPartially.html#27">27</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/PageAction.html#L85">85</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/PageAction.html#L89">89</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/component/UIMenuSelectOne.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocomponentUIMenuSelectOne.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/PageActionEvent.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventPageActionEvent.java"></a></h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/UIMenuSelectOne.html#33">33</a></td>
+ <td>Private field 'action' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/PageActionEvent.html#L31">31</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/config/TobagoConfig.java<a
- name="Tobago_Core_-_orgapachemyfacestobagoconfigTobagoConfig.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/PopupActionListener.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventPopupActionListener.java"></a></h3>
<table border="0" class="bodyTable">
<tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/config/TobagoConfig.html#37">37</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/config/TobagoConfig.html#37">37</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/PopupActionListener.html#L37">37</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/PopupActionListener.html#L38">38</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/ClientProperties.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextClientProperties.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/PopupFacetActionListener.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventPopupFacetActionListener.java"></a></h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (static property access)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#154">154</a></td>
- </tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#155">155</a></td>
- </tr>
- <tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#155">155</a></td>
- </tr>
- <tr class="b">
- <td>Potential violation of Law of Demeter (static property access)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#164">164</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/PopupFacetActionListener.html#L40">40</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/PopupFacetActionListener.html#L46">46</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/ResetInputActionListener.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventResetInputActionListener.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#165">165</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#165">165</a></td>
+ <td>Document empty constructor</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L34">34</a>–<a
+ href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L35">35</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#202">202</a></td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L37">37</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/SortActionEvent.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventSortActionEvent.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#202">202</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="a">
- <td>Use equals() to compare object references.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/ClientProperties.html#204">204</a></td>
+ <td>Private field 'column' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/SortActionEvent.html#L31">31</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3>Tobago Core - org/apache/myfaces/tobago/context/Markup.java<a
- name="Tobago_Core_-_orgapachemyfacestobagocontextMarkup.java"></a></h3>
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/TreeExpansionEvent.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventTreeExpansionEvent.java"></a></h3>
<table border="0" class="bodyTable">
<tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="a">
- <td>This class has too many methods, consider refactoring it.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#50">50</a> - <a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#317">317</a></td>
+ <td>Private field 'oldExpanded' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/TreeExpansionEvent.html#L30">30</a></td>
</tr>
<tr class="b">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#96">96</a></td>
+ <td>Private field 'newExpanded' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/TreeExpansionEvent.html#L31">31</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/TreeMarkedEvent.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventTreeMarkedEvent.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="a">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#106">106</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#110">110</a></td>
+ <td>Private field 'oldMarked' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/TreeMarkedEvent.html#L34">34</a></td>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (object not created locally)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#114">114</a></td>
+ <td>Private field 'newMarked' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/TreeMarkedEvent.html#L35">35</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/TreeSelectedEvent.java<a
+ name="Tobago_Core_-_orgapachemyfacestobagoeventTreeSelectedEvent.java"></a></h3>
+ <table border="0" class="bodyTable">
<tr class="b">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#114">114</a></td>
+ <th>Violation</th>
+ <th>Line</th>
</tr>
<tr class="a">
- <td>Potential violation of Law of Demeter (method chain calls)</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#114">114</a></td>
+ <td>Private field 'oldSelected' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/TreeSelectedEvent.html#L30">30</a></td>
</tr>
<tr class="b">
- <td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#166">166</a></td>
+ <td>Private field 'newSelected' could be made final; it is only initialized in the declaration or
+ constructor.
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/TreeSelectedEvent.html#L31">31</a></td>
</tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3>Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionPopupActionListener.java<a
[... 56955 lines stripped ...]