You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/29 06:43:44 UTC
[GitHub] [flink] dawidwys commented on a change in pull request #9249:
[FLINK-13447][table-api] Change default planner to legacy planner instead
of any one
dawidwys commented on a change in pull request #9249: [FLINK-13447][table-api] Change default planner to legacy planner instead of any one
URL: https://github.com/apache/flink/pull/9249#discussion_r308074578
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/EnvironmentSettings.java
##########
@@ -149,19 +149,26 @@ public boolean isStreamingMode() {
* A builder for {@link EnvironmentSettings}.
*/
public static class Builder {
- private String plannerClass = null;
- private String executorClass = null;
+ private static final String OLD_PLANNER_FACTORY = "org.apache.flink.table.planner.StreamPlannerFactory";
+ private static final String OLD_EXECUTOR_FACTORY = "org.apache.flink.table.executor.StreamExecutorFactory";
+ private static final String BLINK_PLANNER_FACTORY = "org.apache.flink.table.planner.delegation.BlinkPlannerFactory";
+ private static final String BLINK_EXECUTOR_FACTORY = "org.apache.flink.table.planner.delegation.BlinkExecutorFactory";
+
+ private String plannerClass = OLD_PLANNER_FACTORY;
+ private String executorClass = OLD_EXECUTOR_FACTORY;
private String builtInCatalogName = "default_catalog";
private String builtInDatabaseName = "default_database";
private boolean isStreamingMode = true;
/**
* Sets the old Flink planner as the required module. By default, {@link #useAnyPlanner()} is
Review comment:
Please update the javadoc: `By default, {@link #useAnyPlanner()} is` -> `By default, {@link #useOldPlanner()} is`. Also in the remaining two methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services