You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/05/28 17:09:23 UTC
[isis] branch master updated: ISIS-2706: add mignotes
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 801802d ISIS-2706: add mignotes
801802d is described below
commit 801802dc1cc69ba88c3d2231cdc0ef2ba6dd38f8
Author: Andi Huber <ah...@apache.org>
AuthorDate: Fri May 28 19:09:08 2021 +0200
ISIS-2706: add mignotes
---
.../modules/ROOT/pages/2021/2.0.0-M6/mignotes.adoc | 8 +++++
.../services/repository/RepositoryService.java | 36 ----------------------
2 files changed, 8 insertions(+), 36 deletions(-)
diff --git a/antora/components/relnotes/modules/ROOT/pages/2021/2.0.0-M6/mignotes.adoc b/antora/components/relnotes/modules/ROOT/pages/2021/2.0.0-M6/mignotes.adoc
index cb88b3c..8fc1e45 100644
--- a/antora/components/relnotes/modules/ROOT/pages/2021/2.0.0-M6/mignotes.adoc
+++ b/antora/components/relnotes/modules/ROOT/pages/2021/2.0.0-M6/mignotes.adoc
@@ -52,6 +52,14 @@ Module `IsisModuleExtModelAnnotation` was removed and is no longer required.
Service `BookmarkService` has been improved, such that its methods return `Optional<?>` instead of nullable objects.
+Service `RepositoryService.isPersistent(Object domainObject)` has been removed. Use `getEntityState(Object domainObject)` instead.
+
+Service `RepositoryService.isDeleted(Object domainObject)` has been removed. Use `getEntityState(Object domainObject)` instead.
+
+Enum `EntityState.PERSISTABLE_DESTROYED` and `isDestroyed()` were renamed to `PERSISTABLE_REMOVED` and `isRemoved()`. Also note: the `removed` entity life-cycle state is only supported by _JDO_,
+whereas _JPA_ is indifferent to whether an entity instance was `removed` or is `detached`. The framework's JPA integration will always report `detached`.
+
+
The _Wicket Viewer_ was migrated from using _Bootstrap 3_ to _Bootstrap 4_, which might have more or less severe implications on (your) customized _CSS_ and _JavaScript_ and _Wicket_ components.
== Extensions
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/repository/RepositoryService.java b/api/applib/src/main/java/org/apache/isis/applib/services/repository/RepositoryService.java
index 58bc801..6324127 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/repository/RepositoryService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/repository/RepositoryService.java
@@ -93,7 +93,6 @@ public interface RepositoryService {
* all pending changes are flushed to the database when the transaction completes.
* </p>
*
- * @see #isPersistent(Object)
*/
<T> T persist(T domainObject);
@@ -415,40 +414,5 @@ public interface RepositoryService {
return detachedEntity(ofType);
}
-// /**
-// * Determines if the specified object is persistent (that it is stored
-// * permanently outside of the virtual machine
-// * in the object store).
-// *
-// * <p>
-// * This method can also return <code>true</code> if the object has been
-// * {@link #isDeleted(Object) deleted} from the object store.
-// * </p>
-// *
-// * @deprecated due to ambiguous semantic, use
-// * {@link #getEntityState(Object)} instead
-// *
-// * @see #getEntityState(Object)
-// */
-// @Deprecated
-// default boolean isPersistent(Object domainObject) {
-// val entityState = getEntityState(domainObject);
-// return entityState.isAttached() || entityState.isDestroyed();
-// }
-//
-// /**
-// * Determines if the specified object has been deleted from the object store.
-// *
-// * @deprecated due to ambiguous semantic, use
-// * {@link #getEntityState(Object)} instead
-// *
-// * @see #getEntityState(Object)
-// */
-// @Deprecated
-// default boolean isDeleted(Object domainObject) {
-// val entityState = getEntityState(domainObject);
-// return entityState.isDestroyed();
-// }
-
}