[jira] [Closed] (LUCENE-7818) Suspicious condition

["Uwe Schindler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler closed LUCENE-7818.
---------------------------------
    Resolution: Duplicate
      Assignee: Uwe Schindler

I marked this as a duplicate of LUCENE-5365. Issue closed.

> Suspicious condition
> --------------------
>
>                 Key: LUCENE-7818
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7818
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/queryparser
>    Affects Versions: 6.5
>            Reporter: AppChecker
>            Assignee: Uwe Schindler
>              Labels: static-analysis
>
> Hi
> Please, look this [code fragment:|https://github.com/apache/lucene-solr/blob/e2521b2a8baabdaf43b92192588f51e042d21e97/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/util/QueryNodeOperation.java#L57-L60]
> {code}
>     else if (q1 instanceof AndQueryNode)
>       op = ANDOperation.Q1;
>     else if (q1 instanceof AndQueryNode)
>       op = ANDOperation.Q2;
> {code}
> (q1 instanceof AndQueryNode) is checked twice.
> Probably it should be:
> {code}
>     else if (q1 instanceof AndQueryNode)
>       op = ANDOperation.Q1;
>     else if (q2 instanceof AndQueryNode)
>       op = ANDOperation.Q2;
> {code}
> This possible defect found by [AppChecker|https://npo-echelon.ru/en/solutions/appchecker.php]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org