Re: [PR] KAFKA-17609:[3/4]Convert system tests to kraft part 3 [kafka]

["mjsax (via GitHub)" <gi...@apache.org>]

mjsax commented on code in PR #17327:
URL: https://github.com/apache/kafka/pull/17327#discussion_r1803845994


##########
tests/kafkatest/tests/streams/streams_relational_smoke_test.py:
##########
@@ -86,7 +86,7 @@ def __init__(self, test_context):
 
     @cluster(num_nodes=8)
     @matrix(crash=[False, True],
-            processing_guarantee=['exactly_once', 'exactly_once_v2'],
+            processing_guarantee=['exactly_once_v2'],

Review Comment:
   Given that we have only EOSv2 left, should we not just remove this parameter completely?
   
   Given that `exactly_once` was remove from the code base a while ago already, I am wondering why we did not get any failing system test alerts? (Miss on my side to not remove this setting in one of my PRs) -- Or is this test not executed? 🤔 



##########
tests/kafkatest/tests/streams/streams_broker_compatibility_test.py:
##########
@@ -18,34 +18,27 @@
 from ducktape.mark.resource import cluster
 from ducktape.tests.test import Test
 from ducktape.utils.util import wait_until
-from kafkatest.services.kafka import KafkaService
+from kafkatest.services.kafka import KafkaService, quorum
 from kafkatest.services.streams import StreamsBrokerCompatibilityService
 from kafkatest.services.verifiable_consumer import VerifiableConsumer
-from kafkatest.services.zookeeper import ZookeeperService
-from kafkatest.version import LATEST_1_0, LATEST_1_1, \
-    LATEST_2_0, LATEST_2_1, LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5, LATEST_2_6, LATEST_2_7, LATEST_2_8, \
+from kafkatest.version import LATEST_2_8, \
     LATEST_3_0, LATEST_3_1, LATEST_3_2, LATEST_3_3, LATEST_3_4, LATEST_3_5, LATEST_3_6, LATEST_3_7, LATEST_3_8, KafkaVersion
 
 
 class StreamsBrokerCompatibility(Test):
     """
     These tests validates that
-    - Streams works for older brokers 0.11 (or newer)
-    - Streams w/ EOS-alpha works for older brokers 0.11 (or newer)
     - Streams w/ EOS-v2 works for older brokers 2.5 (or newer)
-    - Streams fails fast for older brokers 0.10.0, 0.10.2, and 0.10.1
-    - Streams w/ EOS-v2 fails fast for older brokers 2.4 or older

Review Comment:
   I am not sure why we would need any changes here? For compatibility testing, we should still be able to startup old Kafka with ZK and nothing should really change?
   
   Of course, when using `trunk/4.0` we would start brokers in kraft mode.



##########
tests/kafkatest/tests/streams/streams_relational_smoke_test.py:
##########
@@ -86,7 +86,7 @@ def __init__(self, test_context):
 
     @cluster(num_nodes=8)
     @matrix(crash=[False, True],
-            processing_guarantee=['exactly_once', 'exactly_once_v2'],
+            processing_guarantee=['exactly_once_v2'],
             metadata_quorum=[quorum.isolated_kraft])

Review Comment:
   Seem we can remove this parameter, too, and also switch to `combined_kraft` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org