You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/27 05:18:04 UTC

[GitHub] [arrow] cyb70289 commented on pull request #10154: ARROW-12240: [Python] Fix invalid-offsetof warning

cyb70289 commented on pull request #10154:
URL: https://github.com/apache/arrow/pull/10154#issuecomment-827319070


   Looks we cannot simply using the unique_ptr trick here.
   CSV options should be persistent by pickle. Change data member to pointer crashes related unit tests https://github.com/apache/arrow/blob/ca83a14e264d00c6b4b29560cc2816c6718f52e7/python/pyarrow/tests/test_dataset.py#L617
   
   All compute kernel options are not pickle-able as we've embedded unique_ptr, will it be a problem?
   cc @bkietz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org