You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by chenliang613 <gi...@git.apache.org> on 2015/08/15 09:04:52 UTC
[GitHub] flink pull request: Some updates for programming_guide.md
GitHub user chenliang613 opened a pull request:
https://github.com/apache/flink/pull/1019
Some updates for programming_guide.md
Some updates for the section "Program Skeleton" of programming_guide.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenliang613/flink patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1019.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1019
----
commit a0b17ead729511a856609a6ac80033d30f1dce71
Author: CHEN LIANG <ch...@sina.cn>
Date: 2015-08-15T07:04:08Z
Some updates for programming_guide.md
Some updates for the section "Program Skeleton" of programming_guide.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Some updates for programming_guide.md
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 closed the pull request at:
https://github.com/apache/flink/pull/1019
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Some updates for programming_guide.md
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1019#issuecomment-131578024
This looks good, will merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Some updates for programming_guide.md
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1019#issuecomment-131756217
I merged this in 3c1b5f0e7f28d18868e941712d2ca42b140ef3a0 , but forgot the closing message.
Can you manually close this pull request?
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Some updates for programming_guide.md
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the pull request:
https://github.com/apache/flink/pull/1019#issuecomment-131911333
ok, done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Some updates for programming_guide.md
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the pull request:
https://github.com/apache/flink/pull/1019#issuecomment-131405427
ok, update the sockets part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Some updates for programming_guide.md
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1019#issuecomment-131403119
Most of this is good, but in parts, it confuses the `DataSet` and `DataStream` API. The `DataSet` API has no functionality to write to sockets.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---