[jira] Commented: (SHINDIG-57) gadgets.io.makeRequest does not pass a content-type on POST requests

["Kevin Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567367#action_12567367 ] 

Kevin Brown commented on SHINDIG-57:
------------------------------------

POST requests aren't always necessarily application/x-www-form-urlencoded. That's only when you're dealing with form encoded key-value pairs.

We should pass through the content type headers, but forcing www-form-urlencoded is no the right way to go because we still need to support other request types (especially for RPC servers).

Until this can be dropped in, a workaround for php is to manually parse the post data as follows:

$postData = file_get_contents('php://input');

$values = explode('&',$postData);

for ($i = 0, $j = count($values); $i <  $j; $i += 2) {
  $_POST[$values[$i]] = $values[$i + 1];
}

I'll drop in a patch to correctly pass through headers shortly.

> gadgets.io.makeRequest does not pass a content-type on POST requests
> --------------------------------------------------------------------
>
>                 Key: SHINDIG-57
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-57
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadgets Server - Java
>            Reporter: Arne Roomann-Kurrik
>            Assignee: John Hjelmstad
>         Attachments: add-content-type.patch.txt
>
>
> When using gadgets.io.makeRequest to POST data to a remote server, the Content-Type header is not set.  
> PHP expects the Content-Type header to be set to "application/x-www-form-urlencoded" in order to populate its $_POST variable with the passed data.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.