You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/13 02:00:57 UTC

[GitHub] [arrow-rs] tustvold commented on pull request #2041: Add support of converting `FixedSizeBinaryArray` to `DecimalArray`

tustvold commented on PR #2041:
URL: https://github.com/apache/arrow-rs/pull/2041#issuecomment-1182674582

   > if the features=force_validate is set.
   
   This is very much a testing only feature, this enables validation **everywhere** and will absolutely tank performance. It is a MIRI-light
   
   >  BTW, when we get a decimal value from Decimal::value(i), we also don't validate the range.
   
   That is likely because the general assumption within arrow-rs is you can't construct an invalid ArrayData without using an unsafe API. This does not appear to be true of Decimal, at least at the moment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org