[jira] [Commented] (RYA-401) Charset issue with RdfCloudTripleStoreTest.testForeignSelectOnlyQuery()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RYA-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201915#comment-16201915 ] 

ASF GitHub Bot commented on RYA-401:
------------------------------------

GitHub user jdasch opened a pull request:

    https://github.com/apache/incubator-rya/pull/243

    RYA-401 Added findbugs policy to build, fixed all default charset bugs.

    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    
      http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
    ## Description
    - Added a findbugs policy for default encoding bugs
    - fixed all default encoding bugs
    - removed the maven-surefire-plugin's -Dfile.encoding=UTF-8 argLine
    
    ### Tests
    N/A
    
    ### Links
    [Jira RYA-401](https://issues.apache.org/jira/browse/RYA-401)
    
    ### Checklist
    - [ ] Code Review
    - [X] Squash Commits
    
    #### People To Reivew
    @meiercaleb 
    @isper3at 
    @amihalik 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdasch/incubator-rya RYA-401

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #243
    
----
commit 55a23084afb9ca8a4f0c93ea9baedb6fbfeaf15c
Author: jdasch <hc...@gmail.com>
Date:   2017-10-11T13:10:38Z

    RYA-401 Added findbugs policy to build, fixed all default charset bugs.
    
    - removed the maven-surefire-plugin's -Dfile.encoding=UTF-8 argLine

----


> Charset issue with RdfCloudTripleStoreTest.testForeignSelectOnlyQuery()
> -----------------------------------------------------------------------
>
>                 Key: RYA-401
>                 URL: https://issues.apache.org/jira/browse/RYA-401
>             Project: Rya
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.2.11
>            Reporter: Jeff Dasch
>            Assignee: Jeff Dasch
>            Priority: Minor
>
> {{RdfCloudTripleStoreTest.testForeignSelectOnlyQuery()}} fails when {{-Dfile.encoding=ISO-8859-1}}
> Current workaround is to force {{-Dfile.encoding=UTF-8}} in the maven-surefire-plugin definition for rya-project's pom.xml.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)