You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (Created) (JIRA)" <ji...@apache.org> on 2011/12/11 22:18:39 UTC
[jira] [Created] (LUCENE-3640) remove IndexSearcher.close
remove IndexSearcher.close
--------------------------
Key: LUCENE-3640
URL: https://issues.apache.org/jira/browse/LUCENE-3640
Project: Lucene - Java
Issue Type: Improvement
Reporter: Michael McCandless
Assignee: Michael McCandless
Fix For: 3.6, 4.0
Now that IS is never "heavy" (since you have to pass in your own IR), IS.close is truly a no-op... I think we should remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3640) remove IndexSearcher.close
Posted by "Koji Sekiguchi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi updated LUCENE-3640:
-----------------------------------
Fix Version/s: (was: 3.6)
remove 3.6 tag from Fix Version/s
> remove IndexSearcher.close
> --------------------------
>
> Key: LUCENE-3640
> URL: https://issues.apache.org/jira/browse/LUCENE-3640
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.0
>
> Attachments: LUCENE-3640.patch, LUCENE-3640.patch
>
>
> Now that IS is never "heavy" (since you have to pass in your own IR), IS.close is truly a no-op... I think we should remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Resolved] (LUCENE-3640) remove IndexSearcher.close
Posted by Koji Sekiguchi <ko...@r.email.ne.jp>.
(11/12/12 9:22), Robert Muir (Resolved) (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/LUCENE-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Robert Muir resolved LUCENE-3640.
> ---------------------------------
>
> Resolution: Fixed
>
>> remove IndexSearcher.close
>> --------------------------
>>
>> Key: LUCENE-3640
>> URL: https://issues.apache.org/jira/browse/LUCENE-3640
>> Project: Lucene - Java
>> Issue Type: Improvement
>> Reporter: Michael McCandless
>> Assignee: Michael McCandless
>> Fix For: 3.6, 4.0
I couldn't find any commit logs in 3x. Isn't it just for trunk?
koji
--
Check out "Query Log Visualizer" for Apache Solr
http://www.rondhuit-demo.com/loganalyzer/loganalyzer.html
http://www.rondhuit.com/en/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3640) remove IndexSearcher.close
Posted by "Robert Muir (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-3640.
---------------------------------
Resolution: Fixed
> remove IndexSearcher.close
> --------------------------
>
> Key: LUCENE-3640
> URL: https://issues.apache.org/jira/browse/LUCENE-3640
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3640.patch, LUCENE-3640.patch
>
>
> Now that IS is never "heavy" (since you have to pass in your own IR), IS.close is truly a no-op... I think we should remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3640) remove IndexSearcher.close
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167313#comment-13167313 ]
Robert Muir commented on LUCENE-3640:
-------------------------------------
Should not have been marked for 3.6... in 3.6 you can still open an IndexSearcher over a Directory and it manages the Reader instance in that case (so you should call close).
I started trying to backport test fixes, but i found 3.x's tests are massively out of sync with trunk, mostly using tons of deprecated APIs. I'll try to see if i can sync up the tests a bit, otherwise backporting in general is going to get difficult.
> remove IndexSearcher.close
> --------------------------
>
> Key: LUCENE-3640
> URL: https://issues.apache.org/jira/browse/LUCENE-3640
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.0
>
> Attachments: LUCENE-3640.patch, LUCENE-3640.patch
>
>
> Now that IS is never "heavy" (since you have to pass in your own IR), IS.close is truly a no-op... I think we should remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3640) remove IndexSearcher.close
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167289#comment-13167289 ]
Uwe Schindler commented on LUCENE-3640:
---------------------------------------
The fix for the readerFinishedLister is cool, as the listener gets called for a lot of readers, also those closed during reopen...
> remove IndexSearcher.close
> --------------------------
>
> Key: LUCENE-3640
> URL: https://issues.apache.org/jira/browse/LUCENE-3640
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3640.patch, LUCENE-3640.patch
>
>
> Now that IS is never "heavy" (since you have to pass in your own IR), IS.close is truly a no-op... I think we should remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3640) remove IndexSearcher.close
Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3640:
--------------------------------
Attachment: LUCENE-3640.patch
updated patch: all tests pass.
I would like to commit soon so the patch does not grow out of date.
> remove IndexSearcher.close
> --------------------------
>
> Key: LUCENE-3640
> URL: https://issues.apache.org/jira/browse/LUCENE-3640
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3640.patch, LUCENE-3640.patch
>
>
> Now that IS is never "heavy" (since you have to pass in your own IR), IS.close is truly a no-op... I think we should remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3640) remove IndexSearcher.close
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167213#comment-13167213 ]
Uwe Schindler commented on LUCENE-3640:
---------------------------------------
+1
> remove IndexSearcher.close
> --------------------------
>
> Key: LUCENE-3640
> URL: https://issues.apache.org/jira/browse/LUCENE-3640
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.6, 4.0
>
>
> Now that IS is never "heavy" (since you have to pass in your own IR), IS.close is truly a no-op... I think we should remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3640) remove IndexSearcher.close
Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3640:
--------------------------------
Attachment: LUCENE-3640.patch
here's a patch... some tests are angry about what i did in LuceneTestCase though.
> remove IndexSearcher.close
> --------------------------
>
> Key: LUCENE-3640
> URL: https://issues.apache.org/jira/browse/LUCENE-3640
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3640.patch
>
>
> Now that IS is never "heavy" (since you have to pass in your own IR), IS.close is truly a no-op... I think we should remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org