You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Benoy Antony (JIRA)" <ji...@apache.org> on 2014/05/11 00:15:21 UTC

[jira] [Updated] (HADOOP-10590) ServiceAuthorizationManager is not threadsafe

     [ https://issues.apache.org/jira/browse/HADOOP-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benoy Antony updated HADOOP-10590:
----------------------------------

    Attachment: HADOOP-10590.patch

Attaching a patch which makes the field in _ServiceAuthorizationManager_ _volatile_ instead of synchronizing mutators and accessors.
Since the state is _volatile_, the effectively mutable state is safely published and hence correctly visible to all threads accessing the state.

To understand more on the validity of this safe publication approach, please see https://issues.apache.org/jira/browse/HADOOP-10448?focusedCommentId=13980112


> ServiceAuthorizationManager  is not threadsafe
> ----------------------------------------------
>
>                 Key: HADOOP-10590
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10590
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.4.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>         Attachments: HADOOP-10590.patch
>
>
> The mutators in ServiceAuthorizationManager  are synchronized. The accessors are not synchronized.
> This results in visibility issues when  ServiceAuthorizationManager's state is accessed from different threads.



--
This message was sent by Atlassian JIRA
(v6.2#6252)