You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/01 01:14:56 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
jbertram opened a new pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-770937774
@michaelandrepearce , that's a fair point. Although, the `isDirectDeliver()` method is only used by _other_ classes and not the queue itself to determine whether or not delivery should be direct. Therefore, the changes will almost certainly need to be more invasive than the simple solution you've suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-770647436
Why not in LVQQueue impl override isDirectDeliver() logic and get it to return false if non destructive, so that all the code around LVQ is in just the queue code. Rather than leaching it out to consumer or other code parts, which should be agnostic to queue detail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-771120327
@michaelandrepearce, I isolated the changes to `org.apache.activemq.artemis.core.server.impl.LastValueQueue`. Let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-770972419
@michaelandrepearce, agreed. I'm already working on a solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-770647436
Why not in LVQQueue impl override isDirectDeliver() logic and get it to return false if non destructive, so that all the code around LVQ is in just the queue code. Rather than leaching it out to consumer or other code parts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-770647436
Why not in LVQQueue impl override isDirectDeliver() logic and get it to return false if non destructive, so that all the code around LVQ is in just the queue code. Rather than leaching it out to consumer or other code parts, which should be agnostic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-771152890
@jbertram would make sense LastValueQueue and direct deliver?
I saw a previous version (before your interaction with @michaelandrepearce )... and I understand that.. but on an overall case ... would make sense direct deliver and LastValue Queue? shouldn't we really return false on Issupportdirectdeliver method for LVQ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-771165658
As noted previously changing the return value of `isDirectDeliver()` in and of itself won't change the behavior of the queue implementation. The only things which use `isDirectDeliver()` are tests and management.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-771236441
> @michaelandrepearce, I isolated the changes to `org.apache.activemq.artemis.core.server.impl.LastValueQueue`. Let me know what you think.
Just saw it. Nice and clean change. And only two lines!! +1 from me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-771236441
> @michaelandrepearce, I isolated the changes to `org.apache.activemq.artemis.core.server.impl.LastValueQueue`. Let me know what you think.
Just saw it. Nice and clean change. And only two lines!! +1 from me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3424: ARTEMIS-3089 direct delivery can break LVQ+non-destructive
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3424:
URL: https://github.com/apache/activemq-artemis/pull/3424#issuecomment-770967800
I think we should somehow find a way so its self contained still
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org