You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "lukaszlenart (via GitHub)" <gi...@apache.org> on 2026/07/27 09:34:29 UTC
[PR] Clear Show Diagram Plugin Verifier deprecated APIs [struts-intellij-plugin]
lukaszlenart opened a new pull request, #132:
URL: https://github.com/apache/struts-intellij-plugin/pull/132
## Summary
- Replace leftover `ReadAction.compute` call sites in Show Diagram (`StrutsDiagramVfsResolver` + provider tests) with `ReadAction.nonBlocking().executeSynchronously()`
- Drop the deprecated `DiagramExtras.createNodeComponent(..., Point, ...)` override; keep the `NodeRealizer` overload for compact label nodes
- Document the cleanup in CHANGELOG and add design/plan under `docs/superpowers/`
## Test plan
- [x] `./gradlew test -x rat --tests "com.intellij.struts2.diagram.*"` (49 tests green)
- [x] `./gradlew verifyPlugin` — zero hits for `DiagramExtras.createNodeComponent` and `ReadAction.compute(ThrowableComputable)`
- [ ] Manual `runIde` smoke: Show Diagram compact icon+label nodes + Jump to Source / double-click navigation
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear Show Diagram Plugin Verifier deprecated APIs [struts-intellij-plugin]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #132:
URL: https://github.com/apache/struts-intellij-plugin/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear Show Diagram Plugin Verifier deprecated APIs [struts-intellij-plugin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #132:
URL: https://github.com/apache/struts-intellij-plugin/pull/132#issuecomment-5089814590
<!-- plugin-artifact-comment -->
🔌 **Plugin artifact ready for testing!**
Download from [Actions artifacts](https://github.com/apache/struts-intellij-plugin/actions/runs/30254535109#artifacts)
Artifact: `struts2-262.19039.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear Show Diagram Plugin Verifier deprecated APIs [struts-intellij-plugin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #132:
URL: https://github.com/apache/struts-intellij-plugin/pull/132#issuecomment-5089903085
# Qodana for JVM
**It seems all right 👌**
No new problems were found according to the checks applied
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
<details>
<summary>View the detailed Qodana report</summary>
To be able to view the detailed Qodana report, you can either:
- Register at [Qodana Cloud](https://qodana.cloud/) and [configure the action](https://github.com/jetbrains/qodana-action#qodana-cloud)
- Use [GitHub Code Scanning with Qodana](https://github.com/jetbrains/qodana-action#github-code-scanning)
- Host [Qodana report at GitHub Pages](https://github.com/JetBrains/qodana-action/blob/3a8e25f5caad8d8b01c1435f1ef7b19fe8b039a0/README.md#github-pages)
- Inspect and use `qodana.sarif.json` (see [the Qodana SARIF format](https://www.jetbrains.com/help/qodana/qodana-sarif-output.html#Report+structure) for details)
To get `*.log` files or any other Qodana artifacts, run the action with `upload-result` option set to `true`,
so that the action will upload the files as the job artifacts:
```yaml
- name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2026.1.3
with:
upload-result: true
```
</details>
<details>
<summary>Contact Qodana team</summary>
Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com)
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
</details>
<!-- JetBrains/qodana-action@v2026.1.3 : Qodana for JVM, -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org