[GitHub] [arrow-rs] viirya commented on a diff in pull request #3006: Replace hour_generic with hour_dyn

[GitBox <gi...@apache.org>]

viirya commented on code in PR #3006:
URL: https://github.com/apache/arrow-rs/pull/3006#discussion_r1012359729


##########
arrow/src/compute/kernels/temporal.rs:
##########
@@ -180,21 +182,69 @@ where
     T: ArrowTemporalType + ArrowNumericType,
     i64: From<T::Native>,
 {
-    hour_generic::<T, _>(array)
+    hour_internal::<T, _>(array, array.data_type())
 }
 
-/// Extracts the hours of a given temporal array as an array of integers within
-/// the range of [0, 23].
-pub fn hour_generic<T, A: ArrayAccessor<Item = T::Native>>(array: A) -> Result<Int32Array>

Review Comment:
   I remove it directly. Let me know if you think it is better to deprecate it first. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org