You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2025/03/27 23:33:43 UTC
Re: [PR] added Pause option into minor compactions [accumulo]
keith-turner commented on code in PR #5289:
URL: https://github.com/apache/accumulo/pull/5289#discussion_r2017720342
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java:
##########
@@ -41,6 +42,8 @@ class MinorCompactionTask implements Runnable {
private final long flushId;
private final MinorCompactionReason mincReason;
+ private final long pauseLimit;
Review Comment:
Is anything reading this variable?
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -603,9 +603,9 @@ private MinorCompactionTask createMinorCompactionTask(long flushId,
logMessage.append(" tabletMemory.memoryReservedForMinC() "
+ getTabletMemory().memoryReservedForMinC());
}
- if (getTabletMemory() != null && getTabletMemory().getMemTable() != null) {
- logMessage.append(" tabletMemory.getMemTable().getNumEntries() "
- + getTabletMemory().getMemTable().getNumEntries());
+ if (mincReason == MinorCompactionReason.SYSTEM) {
+ logMessage.append(" fileCount " + getDatafiles().size());
+ logMessage.append(" fileCountPauseLimit " + pauseLimit);
Review Comment:
Could add another condition so that this information is only appended to the log message when it was the pause limit that caused the tablet to not minor compact.
```suggestion
if (mincReason == MinorCompactionReason.SYSTEM && getDatafiles().size() >= pauseLimit) {
logMessage.append(" fileCount " + getDatafiles().size());
logMessage.append(" fileCountPauseLimit " + pauseLimit);
```
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -603,9 +603,9 @@ private MinorCompactionTask createMinorCompactionTask(long flushId,
logMessage.append(" tabletMemory.memoryReservedForMinC() "
+ getTabletMemory().memoryReservedForMinC());
}
- if (getTabletMemory() != null && getTabletMemory().getMemTable() != null) {
Review Comment:
Was this unreachable code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org