[GitHub] [hbase] huaxiangsun commented on a change in pull request #3729: HBASE-26327 Replicas cohosted on a rack shouldn't keep triggering Bal…

[GitBox <gi...@apache.org>]

huaxiangsun commented on a change in pull request #3729:
URL: https://github.com/apache/hbase/pull/3729#discussion_r734714824



##########
File path: hbase-balancer/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancerRegionReplica.java
##########
@@ -161,8 +161,7 @@ public void testNeedsBalanceForColocatedReplicas() {
     map.put(s2, regionsOnS2);
     // add another server so that the cluster has some host on another rack
     map.put(ServerName.valueOf("host2", 1000, 11111), randomRegions(1));
-    assertFalse(
-      loadBalancer.needsBalance(HConstants.ENSEMBLE_TABLE_NAME,
+    assertTrue(!loadBalancer.needsBalance(HConstants.ENSEMBLE_TABLE_NAME,

Review comment:
       Does it make any difference with the change?
   assertFalse(func()) <==> assertTrue(!func())




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org