You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by Bryant Luk <br...@gmail.com> on 2009/09/29 22:43:05 UTC
Re: [jira] Issue Comment Edited: (WINK-183) wink-providers must be
included in the distribution archive
Jira isn't working well for the past few hours for me. I'm assuming
that the lib directory underneath ext for the abdera/jettison/json
ones are including their library JARs for them?
Also, is the plan to stick with the Ant build or use the maven-assembly-plugin?
On Tue, Sep 29, 2009 at 5:44 AM, Michael Elman (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/WINK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760534#action_12760534 ]
>
> Michael Elman edited comment on WINK-183 at 9/29/09 3:43 AM:
> -------------------------------------------------------------
>
> I suggest the following zip structure:
> * *apache\-wink*
> ** *dist*
> *** wink.jar - includes common, client, server, webdav, spring, apache-httpclient, anything else?
> *** wink-client.jar
> *** wink-common.jar
> *** wink-server.jar
> ** *docs*
> ** *examples*
> *** *apps*
> *** *client*
> *** *core*
> *** *ext*
> *** *lib* - additional libraries required for example compilation
> ** *lib* - only libraries required by client, common and server
> ** *ext* - extensions
> *** *apache-httpclient*
> **** *lib*
> *** *spring*
> **** *lib*
> *** *webdav*
> *** *abdera*
> **** *lib*
> *** *jettison*
> **** *lib*
> *** *json*
> **** *lib*
>
> In general the proposed changes are:
> # Moving extensions under the *ext* folder.
> # If extension requires third parties, put them under relevant lib folder (e.g. ext\abdera\lib)
> # Lib folder will contain only common, client and server dependencies.
> # Third parties that are required for the examples Ant compilation, put under *examples\lib*.
> # *wink.jar* will contain most of the extensions (all extensions?), but it won't contain {{wink-application}} for the providers auto-registration.
>
> Thoughts?
>
> was (Author: elman):
> I suggest the following zip structure:
> * *apache\-wink*
> ** *dist*
> *** wink.jar - includes common, client, server, webdav, spring, apache-httpclient, anything else?
> *** wink-client.jar
> *** wink-common.jar
> *** wink-server.jar
> ** *docs*
> ** *examples*
> *** *aps*
> *** *client*
> *** *core*
> *** *ext*
> *** *lib* - additional libraries required for example compilation
> ** *lib* - only libraries required by client, common and server
> ** *ext* - extensions
> *** *apache-httpclient*
> **** *lib*
> *** *spring*
> **** *lib*
> *** *webdav*
> *** *abdera*
> **** *lib*
> *** *jettison*
> **** *lib*
> *** *json*
> **** *lib*
>
> In general the proposed changes are:
> # Moving extensions under the *ext* folder.
> # If extension requires third parties, put them under relevant lib folder (e.g. ext\abdera\lib)
> # Lib folder will contain only common, client and server dependencies.
> # Third parties that are required for the examples Ant compilation, put under *examples\lib*.
> # *wink.jar* will contain most of the extensions (all extensions?), but it won't contain {{wink-application}} for the providers auto-registration.
>
> Thoughts?
>
>> wink-providers must be included in the distribution archive
>> -----------------------------------------------------------
>>
>> Key: WINK-183
>> URL: https://issues.apache.org/jira/browse/WINK-183
>> Project: Wink
>> Issue Type: Bug
>> Components: Providers
>> Affects Versions: 0.2
>> Reporter: Michael Elman
>> Assignee: Michael Elman
>> Priority: Blocker
>> Fix For: 0.2
>>
>>
>> wink-providers must be included in the distribution archive.
>> Ant scripts of some examples should be also changed (may be it's a good time to remove these scripts?) to address json providers.
>> This is a blocking issue for 0.2.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
- Bryant Luk
Re: [jira] Issue Comment Edited: (WINK-183) wink-providers must be
included in the distribution archive
Posted by Bryant Luk <br...@gmail.com>.
I'll take a look. The only other thing that might need some more
thorough reviews is the NOTICE, LICENSE, etc. to make sure that we're
all legally clear with the dependencies. I also seem to remember Sebb
in the last release made some comments that the NOTICE file in the
wink.jar wasn't listing everything correctly but it was a non-blocker
at the time.
On Thu, Oct 1, 2009 at 7:13 AM, Michael Elman <ta...@gmail.com> wrote:
> I applied the suggested fixed.
> Please, review the distribution archive and let me know if there are any
> other issues.
> I think we should head towards the 1.0 release and it will be helpful is the
> distribution archive is built properly.
>
> On Wed, Sep 30, 2009 at 8:06 AM, Michael Elman <ta...@gmail.com> wrote:
>
>> >I'm assuming that the lib directory underneath ext for the
>> abdera/jettison/json ones are including their library JARs for them?
>> Short answer: Yes.
>> Long answer: The folder will include dependencies of the module, minus the
>> dependencies that were already included in the main lib folder.
>>
>> >Also, is the plan to stick with the Ant build or use the
>> maven-assembly-plugin?
>> As a fast solution, I'd like to stick with Ant.
>> Once I tried to work with maven-assembly-plugin and found out that it's
>> very complex to perform some tasks using it. Especially working with
>> multiple submodules doesn't work well.
>> But I'll really appreciate if someone moves this script to maven. There is
>> a separate Jira (WINK-67) opened for it and assigned to Jason.
>>
>>
>> On Tue, Sep 29, 2009 at 10:43 PM, Bryant Luk <br...@gmail.com> wrote:
>>
>>> Jira isn't working well for the past few hours for me. I'm assuming
>>> that the lib directory underneath ext for the abdera/jettison/json
>>> ones are including their library JARs for them?
>>>
>>> Also, is the plan to stick with the Ant build or use the
>>> maven-assembly-plugin?
>>>
>>> On Tue, Sep 29, 2009 at 5:44 AM, Michael Elman (JIRA) <ji...@apache.org>
>>> wrote:
>>> >
>>> > [
>>> https://issues.apache.org/jira/browse/WINK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760534#action_12760534]
>>> >
>>> > Michael Elman edited comment on WINK-183 at 9/29/09 3:43 AM:
>>> > -------------------------------------------------------------
>>> >
>>> > I suggest the following zip structure:
>>> > * *apache\-wink*
>>> > ** *dist*
>>> > *** wink.jar - includes common, client, server, webdav, spring,
>>> apache-httpclient, anything else?
>>> > *** wink-client.jar
>>> > *** wink-common.jar
>>> > *** wink-server.jar
>>> > ** *docs*
>>> > ** *examples*
>>> > *** *apps*
>>> > *** *client*
>>> > *** *core*
>>> > *** *ext*
>>> > *** *lib* - additional libraries required for example compilation
>>> > ** *lib* - only libraries required by client, common and server
>>> > ** *ext* - extensions
>>> > *** *apache-httpclient*
>>> > **** *lib*
>>> > *** *spring*
>>> > **** *lib*
>>> > *** *webdav*
>>> > *** *abdera*
>>> > **** *lib*
>>> > *** *jettison*
>>> > **** *lib*
>>> > *** *json*
>>> > **** *lib*
>>> >
>>> > In general the proposed changes are:
>>> > # Moving extensions under the *ext* folder.
>>> > # If extension requires third parties, put them under relevant lib
>>> folder (e.g. ext\abdera\lib)
>>> > # Lib folder will contain only common, client and server dependencies.
>>> > # Third parties that are required for the examples Ant compilation, put
>>> under *examples\lib*.
>>> > # *wink.jar* will contain most of the extensions (all extensions?), but
>>> it won't contain {{wink-application}} for the providers auto-registration.
>>> >
>>> > Thoughts?
>>> >
>>> > was (Author: elman):
>>> > I suggest the following zip structure:
>>> > * *apache\-wink*
>>> > ** *dist*
>>> > *** wink.jar - includes common, client, server, webdav, spring,
>>> apache-httpclient, anything else?
>>> > *** wink-client.jar
>>> > *** wink-common.jar
>>> > *** wink-server.jar
>>> > ** *docs*
>>> > ** *examples*
>>> > *** *aps*
>>> > *** *client*
>>> > *** *core*
>>> > *** *ext*
>>> > *** *lib* - additional libraries required for example compilation
>>> > ** *lib* - only libraries required by client, common and server
>>> > ** *ext* - extensions
>>> > *** *apache-httpclient*
>>> > **** *lib*
>>> > *** *spring*
>>> > **** *lib*
>>> > *** *webdav*
>>> > *** *abdera*
>>> > **** *lib*
>>> > *** *jettison*
>>> > **** *lib*
>>> > *** *json*
>>> > **** *lib*
>>> >
>>> > In general the proposed changes are:
>>> > # Moving extensions under the *ext* folder.
>>> > # If extension requires third parties, put them under relevant lib
>>> folder (e.g. ext\abdera\lib)
>>> > # Lib folder will contain only common, client and server dependencies.
>>> > # Third parties that are required for the examples Ant compilation, put
>>> under *examples\lib*.
>>> > # *wink.jar* will contain most of the extensions (all extensions?), but
>>> it won't contain {{wink-application}} for the providers auto-registration.
>>> >
>>> > Thoughts?
>>> >
>>> >> wink-providers must be included in the distribution archive
>>> >> -----------------------------------------------------------
>>> >>
>>> >> Key: WINK-183
>>> >> URL: https://issues.apache.org/jira/browse/WINK-183
>>> >> Project: Wink
>>> >> Issue Type: Bug
>>> >> Components: Providers
>>> >> Affects Versions: 0.2
>>> >> Reporter: Michael Elman
>>> >> Assignee: Michael Elman
>>> >> Priority: Blocker
>>> >> Fix For: 0.2
>>> >>
>>> >>
>>> >> wink-providers must be included in the distribution archive.
>>> >> Ant scripts of some examples should be also changed (may be it's a good
>>> time to remove these scripts?) to address json providers.
>>> >> This is a blocking issue for 0.2.
>>> >
>>> > --
>>> > This message is automatically generated by JIRA.
>>> > -
>>> > You can reply to this email to add a comment to the issue online.
>>> >
>>> >
>>>
>>>
>>>
>>> --
>>>
>>> - Bryant Luk
>>>
>>
>>
>
Re: [jira] Issue Comment Edited: (WINK-183) wink-providers must be
included in the distribution archive
Posted by Michael Elman <ta...@gmail.com>.
1) The PDF should be updated in the SVN.
Regarding the link: not sure how we can put it in the archive. Release
notes?
I think it's still convenient to have also a PDF.
2) Yep, I did it as Nick suggested.
I guess we should update the release notes with information what exactly
wink.jar includes.
3) It's very hard to maintain the extensions libraries. The only filtering I
did, was excluding dependencies that appear in the main lib.
May be some dependencies may be excluded using "exclude" option in the
dependencies management.
On Sat, Oct 3, 2009 at 10:10 PM, Bryant Luk <br...@gmail.com> wrote:
> I like the distribution layout. Some observations:
>
> 1) Need to include a more recent PDF and probably point to the wiki
> for the latest documentation. Personally, I prefer just pointing to
> the wiki as we can update and expand the documentation if necessary
> and then no one would have outdated information.
>
> 2) I didn't see all of the extensions (I think only Spring, WebDav,
> and Apache HttpClient) in the wink.jar. I prefer the way it is now so
> users would need to include their own Jettison, Jackson, etc. jar.
> Just mentioning since it may catch some users by surprise and they
> might not know which extensions are or are not included (or they might
> think that we should only include server, common, and client).
>
> 3) For Abdera, there's a lot of libraries included when I built it,
> some of which are even in other extensions. I think that will cause
> our NOTICE file to grow tremendously.
>
> 4) The NOTICE, DISCLAIMER, and DEPENDENCIES files in the wink.jar
> META-INF/ need to be updated. When I built it, it used the Wink
> Spring module versions. I think I put a version in wink-dist to have
> the build.xml include hand-edited versions for the aggregator JAR.
> Don't know if there's a problem with that.
>
> Played around with the maven-assembly-plugin but it's a bit heavy to
> do simple things. Overall though, I do like the layout as it provides
> a "here's the core and here's some cool features" and separates out
> the required libraries logically. Thanks for implementing this
> Michael.
>
> On Thu, Oct 1, 2009 at 7:13 AM, Michael Elman <ta...@gmail.com> wrote:
> > I applied the suggested fixed.
> > Please, review the distribution archive and let me know if there are any
> > other issues.
> > I think we should head towards the 1.0 release and it will be helpful is
> the
> > distribution archive is built properly.
> >
> > On Wed, Sep 30, 2009 at 8:06 AM, Michael Elman <ta...@gmail.com> wrote:
> >
> >> >I'm assuming that the lib directory underneath ext for the
> >> abdera/jettison/json ones are including their library JARs for them?
> >> Short answer: Yes.
> >> Long answer: The folder will include dependencies of the module, minus
> the
> >> dependencies that were already included in the main lib folder.
> >>
> >> >Also, is the plan to stick with the Ant build or use the
> >> maven-assembly-plugin?
> >> As a fast solution, I'd like to stick with Ant.
> >> Once I tried to work with maven-assembly-plugin and found out that it's
> >> very complex to perform some tasks using it. Especially working with
> >> multiple submodules doesn't work well.
> >> But I'll really appreciate if someone moves this script to maven. There
> is
> >> a separate Jira (WINK-67) opened for it and assigned to Jason.
> >>
> >>
> >> On Tue, Sep 29, 2009 at 10:43 PM, Bryant Luk <br...@gmail.com>
> wrote:
> >>
> >>> Jira isn't working well for the past few hours for me. I'm assuming
> >>> that the lib directory underneath ext for the abdera/jettison/json
> >>> ones are including their library JARs for them?
> >>>
> >>> Also, is the plan to stick with the Ant build or use the
> >>> maven-assembly-plugin?
> >>>
> >>> On Tue, Sep 29, 2009 at 5:44 AM, Michael Elman (JIRA) <jira@apache.org
> >
> >>> wrote:
> >>> >
> >>> > [
> >>>
> https://issues.apache.org/jira/browse/WINK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760534#action_12760534
> ]
> >>> >
> >>> > Michael Elman edited comment on WINK-183 at 9/29/09 3:43 AM:
> >>> > -------------------------------------------------------------
> >>> >
> >>> > I suggest the following zip structure:
> >>> > * *apache\-wink*
> >>> > ** *dist*
> >>> > *** wink.jar - includes common, client, server, webdav, spring,
> >>> apache-httpclient, anything else?
> >>> > *** wink-client.jar
> >>> > *** wink-common.jar
> >>> > *** wink-server.jar
> >>> > ** *docs*
> >>> > ** *examples*
> >>> > *** *apps*
> >>> > *** *client*
> >>> > *** *core*
> >>> > *** *ext*
> >>> > *** *lib* - additional libraries required for example compilation
> >>> > ** *lib* - only libraries required by client, common and server
> >>> > ** *ext* - extensions
> >>> > *** *apache-httpclient*
> >>> > **** *lib*
> >>> > *** *spring*
> >>> > **** *lib*
> >>> > *** *webdav*
> >>> > *** *abdera*
> >>> > **** *lib*
> >>> > *** *jettison*
> >>> > **** *lib*
> >>> > *** *json*
> >>> > **** *lib*
> >>> >
> >>> > In general the proposed changes are:
> >>> > # Moving extensions under the *ext* folder.
> >>> > # If extension requires third parties, put them under relevant lib
> >>> folder (e.g. ext\abdera\lib)
> >>> > # Lib folder will contain only common, client and server
> dependencies.
> >>> > # Third parties that are required for the examples Ant compilation,
> put
> >>> under *examples\lib*.
> >>> > # *wink.jar* will contain most of the extensions (all extensions?),
> but
> >>> it won't contain {{wink-application}} for the providers
> auto-registration.
> >>> >
> >>> > Thoughts?
> >>> >
> >>> > was (Author: elman):
> >>> > I suggest the following zip structure:
> >>> > * *apache\-wink*
> >>> > ** *dist*
> >>> > *** wink.jar - includes common, client, server, webdav, spring,
> >>> apache-httpclient, anything else?
> >>> > *** wink-client.jar
> >>> > *** wink-common.jar
> >>> > *** wink-server.jar
> >>> > ** *docs*
> >>> > ** *examples*
> >>> > *** *aps*
> >>> > *** *client*
> >>> > *** *core*
> >>> > *** *ext*
> >>> > *** *lib* - additional libraries required for example compilation
> >>> > ** *lib* - only libraries required by client, common and server
> >>> > ** *ext* - extensions
> >>> > *** *apache-httpclient*
> >>> > **** *lib*
> >>> > *** *spring*
> >>> > **** *lib*
> >>> > *** *webdav*
> >>> > *** *abdera*
> >>> > **** *lib*
> >>> > *** *jettison*
> >>> > **** *lib*
> >>> > *** *json*
> >>> > **** *lib*
> >>> >
> >>> > In general the proposed changes are:
> >>> > # Moving extensions under the *ext* folder.
> >>> > # If extension requires third parties, put them under relevant lib
> >>> folder (e.g. ext\abdera\lib)
> >>> > # Lib folder will contain only common, client and server
> dependencies.
> >>> > # Third parties that are required for the examples Ant compilation,
> put
> >>> under *examples\lib*.
> >>> > # *wink.jar* will contain most of the extensions (all extensions?),
> but
> >>> it won't contain {{wink-application}} for the providers
> auto-registration.
> >>> >
> >>> > Thoughts?
> >>> >
> >>> >> wink-providers must be included in the distribution archive
> >>> >> -----------------------------------------------------------
> >>> >>
> >>> >> Key: WINK-183
> >>> >> URL: https://issues.apache.org/jira/browse/WINK-183
> >>> >> Project: Wink
> >>> >> Issue Type: Bug
> >>> >> Components: Providers
> >>> >> Affects Versions: 0.2
> >>> >> Reporter: Michael Elman
> >>> >> Assignee: Michael Elman
> >>> >> Priority: Blocker
> >>> >> Fix For: 0.2
> >>> >>
> >>> >>
> >>> >> wink-providers must be included in the distribution archive.
> >>> >> Ant scripts of some examples should be also changed (may be it's a
> good
> >>> time to remove these scripts?) to address json providers.
> >>> >> This is a blocking issue for 0.2.
> >>> >
> >>> > --
> >>> > This message is automatically generated by JIRA.
> >>> > -
> >>> > You can reply to this email to add a comment to the issue online.
> >>> >
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>>
> >>> - Bryant Luk
> >>>
> >>
> >>
> >
>
Re: [jira] Issue Comment Edited: (WINK-183) wink-providers must be
included in the distribution archive
Posted by Bryant Luk <br...@gmail.com>.
I like the distribution layout. Some observations:
1) Need to include a more recent PDF and probably point to the wiki
for the latest documentation. Personally, I prefer just pointing to
the wiki as we can update and expand the documentation if necessary
and then no one would have outdated information.
2) I didn't see all of the extensions (I think only Spring, WebDav,
and Apache HttpClient) in the wink.jar. I prefer the way it is now so
users would need to include their own Jettison, Jackson, etc. jar.
Just mentioning since it may catch some users by surprise and they
might not know which extensions are or are not included (or they might
think that we should only include server, common, and client).
3) For Abdera, there's a lot of libraries included when I built it,
some of which are even in other extensions. I think that will cause
our NOTICE file to grow tremendously.
4) The NOTICE, DISCLAIMER, and DEPENDENCIES files in the wink.jar
META-INF/ need to be updated. When I built it, it used the Wink
Spring module versions. I think I put a version in wink-dist to have
the build.xml include hand-edited versions for the aggregator JAR.
Don't know if there's a problem with that.
Played around with the maven-assembly-plugin but it's a bit heavy to
do simple things. Overall though, I do like the layout as it provides
a "here's the core and here's some cool features" and separates out
the required libraries logically. Thanks for implementing this
Michael.
On Thu, Oct 1, 2009 at 7:13 AM, Michael Elman <ta...@gmail.com> wrote:
> I applied the suggested fixed.
> Please, review the distribution archive and let me know if there are any
> other issues.
> I think we should head towards the 1.0 release and it will be helpful is the
> distribution archive is built properly.
>
> On Wed, Sep 30, 2009 at 8:06 AM, Michael Elman <ta...@gmail.com> wrote:
>
>> >I'm assuming that the lib directory underneath ext for the
>> abdera/jettison/json ones are including their library JARs for them?
>> Short answer: Yes.
>> Long answer: The folder will include dependencies of the module, minus the
>> dependencies that were already included in the main lib folder.
>>
>> >Also, is the plan to stick with the Ant build or use the
>> maven-assembly-plugin?
>> As a fast solution, I'd like to stick with Ant.
>> Once I tried to work with maven-assembly-plugin and found out that it's
>> very complex to perform some tasks using it. Especially working with
>> multiple submodules doesn't work well.
>> But I'll really appreciate if someone moves this script to maven. There is
>> a separate Jira (WINK-67) opened for it and assigned to Jason.
>>
>>
>> On Tue, Sep 29, 2009 at 10:43 PM, Bryant Luk <br...@gmail.com> wrote:
>>
>>> Jira isn't working well for the past few hours for me. I'm assuming
>>> that the lib directory underneath ext for the abdera/jettison/json
>>> ones are including their library JARs for them?
>>>
>>> Also, is the plan to stick with the Ant build or use the
>>> maven-assembly-plugin?
>>>
>>> On Tue, Sep 29, 2009 at 5:44 AM, Michael Elman (JIRA) <ji...@apache.org>
>>> wrote:
>>> >
>>> > [
>>> https://issues.apache.org/jira/browse/WINK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760534#action_12760534]
>>> >
>>> > Michael Elman edited comment on WINK-183 at 9/29/09 3:43 AM:
>>> > -------------------------------------------------------------
>>> >
>>> > I suggest the following zip structure:
>>> > * *apache\-wink*
>>> > ** *dist*
>>> > *** wink.jar - includes common, client, server, webdav, spring,
>>> apache-httpclient, anything else?
>>> > *** wink-client.jar
>>> > *** wink-common.jar
>>> > *** wink-server.jar
>>> > ** *docs*
>>> > ** *examples*
>>> > *** *apps*
>>> > *** *client*
>>> > *** *core*
>>> > *** *ext*
>>> > *** *lib* - additional libraries required for example compilation
>>> > ** *lib* - only libraries required by client, common and server
>>> > ** *ext* - extensions
>>> > *** *apache-httpclient*
>>> > **** *lib*
>>> > *** *spring*
>>> > **** *lib*
>>> > *** *webdav*
>>> > *** *abdera*
>>> > **** *lib*
>>> > *** *jettison*
>>> > **** *lib*
>>> > *** *json*
>>> > **** *lib*
>>> >
>>> > In general the proposed changes are:
>>> > # Moving extensions under the *ext* folder.
>>> > # If extension requires third parties, put them under relevant lib
>>> folder (e.g. ext\abdera\lib)
>>> > # Lib folder will contain only common, client and server dependencies.
>>> > # Third parties that are required for the examples Ant compilation, put
>>> under *examples\lib*.
>>> > # *wink.jar* will contain most of the extensions (all extensions?), but
>>> it won't contain {{wink-application}} for the providers auto-registration.
>>> >
>>> > Thoughts?
>>> >
>>> > was (Author: elman):
>>> > I suggest the following zip structure:
>>> > * *apache\-wink*
>>> > ** *dist*
>>> > *** wink.jar - includes common, client, server, webdav, spring,
>>> apache-httpclient, anything else?
>>> > *** wink-client.jar
>>> > *** wink-common.jar
>>> > *** wink-server.jar
>>> > ** *docs*
>>> > ** *examples*
>>> > *** *aps*
>>> > *** *client*
>>> > *** *core*
>>> > *** *ext*
>>> > *** *lib* - additional libraries required for example compilation
>>> > ** *lib* - only libraries required by client, common and server
>>> > ** *ext* - extensions
>>> > *** *apache-httpclient*
>>> > **** *lib*
>>> > *** *spring*
>>> > **** *lib*
>>> > *** *webdav*
>>> > *** *abdera*
>>> > **** *lib*
>>> > *** *jettison*
>>> > **** *lib*
>>> > *** *json*
>>> > **** *lib*
>>> >
>>> > In general the proposed changes are:
>>> > # Moving extensions under the *ext* folder.
>>> > # If extension requires third parties, put them under relevant lib
>>> folder (e.g. ext\abdera\lib)
>>> > # Lib folder will contain only common, client and server dependencies.
>>> > # Third parties that are required for the examples Ant compilation, put
>>> under *examples\lib*.
>>> > # *wink.jar* will contain most of the extensions (all extensions?), but
>>> it won't contain {{wink-application}} for the providers auto-registration.
>>> >
>>> > Thoughts?
>>> >
>>> >> wink-providers must be included in the distribution archive
>>> >> -----------------------------------------------------------
>>> >>
>>> >> Key: WINK-183
>>> >> URL: https://issues.apache.org/jira/browse/WINK-183
>>> >> Project: Wink
>>> >> Issue Type: Bug
>>> >> Components: Providers
>>> >> Affects Versions: 0.2
>>> >> Reporter: Michael Elman
>>> >> Assignee: Michael Elman
>>> >> Priority: Blocker
>>> >> Fix For: 0.2
>>> >>
>>> >>
>>> >> wink-providers must be included in the distribution archive.
>>> >> Ant scripts of some examples should be also changed (may be it's a good
>>> time to remove these scripts?) to address json providers.
>>> >> This is a blocking issue for 0.2.
>>> >
>>> > --
>>> > This message is automatically generated by JIRA.
>>> > -
>>> > You can reply to this email to add a comment to the issue online.
>>> >
>>> >
>>>
>>>
>>>
>>> --
>>>
>>> - Bryant Luk
>>>
>>
>>
>
Re: [jira] Issue Comment Edited: (WINK-183) wink-providers must be
included in the distribution archive
Posted by Michael Elman <ta...@gmail.com>.
I applied the suggested fixed.
Please, review the distribution archive and let me know if there are any
other issues.
I think we should head towards the 1.0 release and it will be helpful is the
distribution archive is built properly.
On Wed, Sep 30, 2009 at 8:06 AM, Michael Elman <ta...@gmail.com> wrote:
> >I'm assuming that the lib directory underneath ext for the
> abdera/jettison/json ones are including their library JARs for them?
> Short answer: Yes.
> Long answer: The folder will include dependencies of the module, minus the
> dependencies that were already included in the main lib folder.
>
> >Also, is the plan to stick with the Ant build or use the
> maven-assembly-plugin?
> As a fast solution, I'd like to stick with Ant.
> Once I tried to work with maven-assembly-plugin and found out that it's
> very complex to perform some tasks using it. Especially working with
> multiple submodules doesn't work well.
> But I'll really appreciate if someone moves this script to maven. There is
> a separate Jira (WINK-67) opened for it and assigned to Jason.
>
>
> On Tue, Sep 29, 2009 at 10:43 PM, Bryant Luk <br...@gmail.com> wrote:
>
>> Jira isn't working well for the past few hours for me. I'm assuming
>> that the lib directory underneath ext for the abdera/jettison/json
>> ones are including their library JARs for them?
>>
>> Also, is the plan to stick with the Ant build or use the
>> maven-assembly-plugin?
>>
>> On Tue, Sep 29, 2009 at 5:44 AM, Michael Elman (JIRA) <ji...@apache.org>
>> wrote:
>> >
>> > [
>> https://issues.apache.org/jira/browse/WINK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760534#action_12760534]
>> >
>> > Michael Elman edited comment on WINK-183 at 9/29/09 3:43 AM:
>> > -------------------------------------------------------------
>> >
>> > I suggest the following zip structure:
>> > * *apache\-wink*
>> > ** *dist*
>> > *** wink.jar - includes common, client, server, webdav, spring,
>> apache-httpclient, anything else?
>> > *** wink-client.jar
>> > *** wink-common.jar
>> > *** wink-server.jar
>> > ** *docs*
>> > ** *examples*
>> > *** *apps*
>> > *** *client*
>> > *** *core*
>> > *** *ext*
>> > *** *lib* - additional libraries required for example compilation
>> > ** *lib* - only libraries required by client, common and server
>> > ** *ext* - extensions
>> > *** *apache-httpclient*
>> > **** *lib*
>> > *** *spring*
>> > **** *lib*
>> > *** *webdav*
>> > *** *abdera*
>> > **** *lib*
>> > *** *jettison*
>> > **** *lib*
>> > *** *json*
>> > **** *lib*
>> >
>> > In general the proposed changes are:
>> > # Moving extensions under the *ext* folder.
>> > # If extension requires third parties, put them under relevant lib
>> folder (e.g. ext\abdera\lib)
>> > # Lib folder will contain only common, client and server dependencies.
>> > # Third parties that are required for the examples Ant compilation, put
>> under *examples\lib*.
>> > # *wink.jar* will contain most of the extensions (all extensions?), but
>> it won't contain {{wink-application}} for the providers auto-registration.
>> >
>> > Thoughts?
>> >
>> > was (Author: elman):
>> > I suggest the following zip structure:
>> > * *apache\-wink*
>> > ** *dist*
>> > *** wink.jar - includes common, client, server, webdav, spring,
>> apache-httpclient, anything else?
>> > *** wink-client.jar
>> > *** wink-common.jar
>> > *** wink-server.jar
>> > ** *docs*
>> > ** *examples*
>> > *** *aps*
>> > *** *client*
>> > *** *core*
>> > *** *ext*
>> > *** *lib* - additional libraries required for example compilation
>> > ** *lib* - only libraries required by client, common and server
>> > ** *ext* - extensions
>> > *** *apache-httpclient*
>> > **** *lib*
>> > *** *spring*
>> > **** *lib*
>> > *** *webdav*
>> > *** *abdera*
>> > **** *lib*
>> > *** *jettison*
>> > **** *lib*
>> > *** *json*
>> > **** *lib*
>> >
>> > In general the proposed changes are:
>> > # Moving extensions under the *ext* folder.
>> > # If extension requires third parties, put them under relevant lib
>> folder (e.g. ext\abdera\lib)
>> > # Lib folder will contain only common, client and server dependencies.
>> > # Third parties that are required for the examples Ant compilation, put
>> under *examples\lib*.
>> > # *wink.jar* will contain most of the extensions (all extensions?), but
>> it won't contain {{wink-application}} for the providers auto-registration.
>> >
>> > Thoughts?
>> >
>> >> wink-providers must be included in the distribution archive
>> >> -----------------------------------------------------------
>> >>
>> >> Key: WINK-183
>> >> URL: https://issues.apache.org/jira/browse/WINK-183
>> >> Project: Wink
>> >> Issue Type: Bug
>> >> Components: Providers
>> >> Affects Versions: 0.2
>> >> Reporter: Michael Elman
>> >> Assignee: Michael Elman
>> >> Priority: Blocker
>> >> Fix For: 0.2
>> >>
>> >>
>> >> wink-providers must be included in the distribution archive.
>> >> Ant scripts of some examples should be also changed (may be it's a good
>> time to remove these scripts?) to address json providers.
>> >> This is a blocking issue for 0.2.
>> >
>> > --
>> > This message is automatically generated by JIRA.
>> > -
>> > You can reply to this email to add a comment to the issue online.
>> >
>> >
>>
>>
>>
>> --
>>
>> - Bryant Luk
>>
>
>
Re: [jira] Issue Comment Edited: (WINK-183) wink-providers must be
included in the distribution archive
Posted by Michael Elman <ta...@gmail.com>.
>I'm assuming that the lib directory underneath ext for the
abdera/jettison/json ones are including their library JARs for them?
Short answer: Yes.
Long answer: The folder will include dependencies of the module, minus the
dependencies that were already included in the main lib folder.
>Also, is the plan to stick with the Ant build or use the
maven-assembly-plugin?
As a fast solution, I'd like to stick with Ant.
Once I tried to work with maven-assembly-plugin and found out that it's very
complex to perform some tasks using it. Especially working with multiple
submodules doesn't work well.
But I'll really appreciate if someone moves this script to maven. There is a
separate Jira (WINK-67) opened for it and assigned to Jason.
On Tue, Sep 29, 2009 at 10:43 PM, Bryant Luk <br...@gmail.com> wrote:
> Jira isn't working well for the past few hours for me. I'm assuming
> that the lib directory underneath ext for the abdera/jettison/json
> ones are including their library JARs for them?
>
> Also, is the plan to stick with the Ant build or use the
> maven-assembly-plugin?
>
> On Tue, Sep 29, 2009 at 5:44 AM, Michael Elman (JIRA) <ji...@apache.org>
> wrote:
> >
> > [
> https://issues.apache.org/jira/browse/WINK-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760534#action_12760534]
> >
> > Michael Elman edited comment on WINK-183 at 9/29/09 3:43 AM:
> > -------------------------------------------------------------
> >
> > I suggest the following zip structure:
> > * *apache\-wink*
> > ** *dist*
> > *** wink.jar - includes common, client, server, webdav, spring,
> apache-httpclient, anything else?
> > *** wink-client.jar
> > *** wink-common.jar
> > *** wink-server.jar
> > ** *docs*
> > ** *examples*
> > *** *apps*
> > *** *client*
> > *** *core*
> > *** *ext*
> > *** *lib* - additional libraries required for example compilation
> > ** *lib* - only libraries required by client, common and server
> > ** *ext* - extensions
> > *** *apache-httpclient*
> > **** *lib*
> > *** *spring*
> > **** *lib*
> > *** *webdav*
> > *** *abdera*
> > **** *lib*
> > *** *jettison*
> > **** *lib*
> > *** *json*
> > **** *lib*
> >
> > In general the proposed changes are:
> > # Moving extensions under the *ext* folder.
> > # If extension requires third parties, put them under relevant lib folder
> (e.g. ext\abdera\lib)
> > # Lib folder will contain only common, client and server dependencies.
> > # Third parties that are required for the examples Ant compilation, put
> under *examples\lib*.
> > # *wink.jar* will contain most of the extensions (all extensions?), but
> it won't contain {{wink-application}} for the providers auto-registration.
> >
> > Thoughts?
> >
> > was (Author: elman):
> > I suggest the following zip structure:
> > * *apache\-wink*
> > ** *dist*
> > *** wink.jar - includes common, client, server, webdav, spring,
> apache-httpclient, anything else?
> > *** wink-client.jar
> > *** wink-common.jar
> > *** wink-server.jar
> > ** *docs*
> > ** *examples*
> > *** *aps*
> > *** *client*
> > *** *core*
> > *** *ext*
> > *** *lib* - additional libraries required for example compilation
> > ** *lib* - only libraries required by client, common and server
> > ** *ext* - extensions
> > *** *apache-httpclient*
> > **** *lib*
> > *** *spring*
> > **** *lib*
> > *** *webdav*
> > *** *abdera*
> > **** *lib*
> > *** *jettison*
> > **** *lib*
> > *** *json*
> > **** *lib*
> >
> > In general the proposed changes are:
> > # Moving extensions under the *ext* folder.
> > # If extension requires third parties, put them under relevant lib folder
> (e.g. ext\abdera\lib)
> > # Lib folder will contain only common, client and server dependencies.
> > # Third parties that are required for the examples Ant compilation, put
> under *examples\lib*.
> > # *wink.jar* will contain most of the extensions (all extensions?), but
> it won't contain {{wink-application}} for the providers auto-registration.
> >
> > Thoughts?
> >
> >> wink-providers must be included in the distribution archive
> >> -----------------------------------------------------------
> >>
> >> Key: WINK-183
> >> URL: https://issues.apache.org/jira/browse/WINK-183
> >> Project: Wink
> >> Issue Type: Bug
> >> Components: Providers
> >> Affects Versions: 0.2
> >> Reporter: Michael Elman
> >> Assignee: Michael Elman
> >> Priority: Blocker
> >> Fix For: 0.2
> >>
> >>
> >> wink-providers must be included in the distribution archive.
> >> Ant scripts of some examples should be also changed (may be it's a good
> time to remove these scripts?) to address json providers.
> >> This is a blocking issue for 0.2.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
>
>
> --
>
> - Bryant Luk
>