You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/25 11:41:21 UTC
[GitHub] [flink] Airblader opened a new pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Airblader opened a new pull request #16291:
URL: https://github.com/apache/flink/pull/16291
## What is the purpose of the change
This introduces `StatementSet#addInsert(TableDescriptor, Table)` as part of FLIP-129.
Documentation is currently only in JavaDocs and extensive documentation will be added in FLINK-23116.
## Brief change log
* Add `StatementSet#addInsert(TableDescriptor, Table)`.
## Verifying this change
This change added tests and can be verified as follows:
* `CalcITCase#testStatementSetInsertUsingTableDescriptor`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16291:
URL: https://github.com/apache/flink/pull/16291#issuecomment-868444237
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6be24ed4de7e8dc16370333e509556de1309dd9a (Fri Jun 25 11:51:25 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16291:
URL: https://github.com/apache/flink/pull/16291#issuecomment-868457160
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6be24ed4de7e8dc16370333e509556de1309dd9a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19546",
"triggerID" : "6be24ed4de7e8dc16370333e509556de1309dd9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6be24ed4de7e8dc16370333e509556de1309dd9a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19546)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #16291:
URL: https://github.com/apache/flink/pull/16291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16291:
URL: https://github.com/apache/flink/pull/16291#issuecomment-868457160
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6be24ed4de7e8dc16370333e509556de1309dd9a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19546",
"triggerID" : "6be24ed4de7e8dc16370333e509556de1309dd9a",
"triggerType" : "PUSH"
}, {
"hash" : "9be0122bbcc4e94d2f7c4534ee7fe4298bcf5609",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9be0122bbcc4e94d2f7c4534ee7fe4298bcf5609",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6be24ed4de7e8dc16370333e509556de1309dd9a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19546)
* 9be0122bbcc4e94d2f7c4534ee7fe4298bcf5609 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #16291:
URL: https://github.com/apache/flink/pull/16291#discussion_r663850447
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/StatementSet.java
##########
@@ -38,6 +38,29 @@
/** add {@link Table} with the given sink table name to the set. */
StatementSet addInsert(String targetPath, Table table, boolean overwrite);
+ /**
+ * Adds a statement to insert {@param table} into a table defined by {@param descriptor}.
Review comment:
```
Adds a statement that the pipeline defined by the given {@link Table} object should be written to a
table (backed by a {@link DynamicTableSink}) and expressed via the given {@link TableDescriptor}.
```
Somehow we should align `executeInsert` and `addInsert`. `StatementSet` is poorly documented right now.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -548,4 +548,29 @@ class CalcITCase extends StreamingTestBase {
TestBaseUtils.compareResultAsText(result, "42")
}
+ @Test
+ def testStatementSetInsertUsingTableDescriptor(): Unit = {
Review comment:
Move to `TableSinkITCase` or better just access the `StatementSet` if possible and avoid a Flink execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16291:
URL: https://github.com/apache/flink/pull/16291#issuecomment-868457160
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6be24ed4de7e8dc16370333e509556de1309dd9a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6be24ed4de7e8dc16370333e509556de1309dd9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6be24ed4de7e8dc16370333e509556de1309dd9a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16291:
URL: https://github.com/apache/flink/pull/16291#issuecomment-868457160
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6be24ed4de7e8dc16370333e509556de1309dd9a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19546",
"triggerID" : "6be24ed4de7e8dc16370333e509556de1309dd9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6be24ed4de7e8dc16370333e509556de1309dd9a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19546)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #16291:
URL: https://github.com/apache/flink/pull/16291#discussion_r663850447
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/StatementSet.java
##########
@@ -38,6 +38,29 @@
/** add {@link Table} with the given sink table name to the set. */
StatementSet addInsert(String targetPath, Table table, boolean overwrite);
+ /**
+ * Adds a statement to insert {@param table} into a table defined by {@param descriptor}.
Review comment:
```
Adds a statement that the pipeline defined by the given {@link Table} object should be written to a
table (backed by a {@link DynamicTableSink}) and expressed via the given {@link TableDescriptor}.
```
Somehow we should align `executeInsert` and `addInsert`. `StatementSet` is poorly documented right now.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -548,4 +548,29 @@ class CalcITCase extends StreamingTestBase {
TestBaseUtils.compareResultAsText(result, "42")
}
+ @Test
+ def testStatementSetInsertUsingTableDescriptor(): Unit = {
Review comment:
Move to `TableSinkITCase` or better just access the `StatementSet` if possible and avoid a Flink execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16291: [FLINK-23071][table-api-java] Introduce StatementSet#addInsert(TableDescriptor, Table)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16291:
URL: https://github.com/apache/flink/pull/16291#issuecomment-868444237
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9be0122bbcc4e94d2f7c4534ee7fe4298bcf5609 (Thu Sep 23 17:59:49 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org