You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rangadi (via GitHub)" <gi...@apache.org> on 2023/07/30 22:50:47 UTC

[GitHub] [spark] rangadi commented on pull request #42193: [SPARK-44432][SS][CONNECT] Terminate streaming queries when a session times out in Spark Connect

rangadi commented on PR #42193:
URL: https://github.com/apache/spark/pull/42193#issuecomment-1657284817

   How is this tested? I think it will not timeout the session on the server at all because we have an explicit feature to keep the session mapping alive (implemented in #40937). 
    Even if the  client disappear, session would be kept alive and thus the queries will  not be cleaned up. 
    I think we need to remove most of  #40937. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org