You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Kate Ting <ka...@cloudera.com> on 2011/11/01 08:39:07 UTC

Review Request: SQOOP-364: Default getCurTimestampQuery() in SqlManager is not working for PostgreSQL

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2657/
-----------------------------------------------------------

Review request for Sqoop and Bilung Lee.


Summary
-------

Postgres can now return the current timestamp.


This addresses bug SQOOP-364.
    https://issues.apache.org/jira/browse/SQOOP-364


Diffs
-----

  src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 6442908 
  src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 574003d 

Diff: https://reviews.apache.org/r/2657/diff


Testing
-------

Unit test added.


Thanks,

Kate


Re: Review Request: SQOOP-364: Default getCurTimestampQuery() in SqlManager is not working for PostgreSQL

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2657/#review2980
-----------------------------------------------------------

Ship it!


Look good! Thanks, Kate.

- Bilung


On 2011-11-01 07:39:07, Kate Ting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2657/
> -----------------------------------------------------------
> 
> (Updated 2011-11-01 07:39:07)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Summary
> -------
> 
> Postgres can now return the current timestamp.
> 
> 
> This addresses bug SQOOP-364.
>     https://issues.apache.org/jira/browse/SQOOP-364
> 
> 
> Diffs
> -----
> 
>   src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 6442908 
>   src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 574003d 
> 
> Diff: https://reviews.apache.org/r/2657/diff
> 
> 
> Testing
> -------
> 
> Unit test added.
> 
> 
> Thanks,
> 
> Kate
> 
>