You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@hamilton.apache.org by "Gophersen (via GitHub)" <gi...@apache.org> on 2025/07/27 20:59:51 UTC
[PR] add license headers to source files #1360 [hamilton]
Gophersen opened a new pull request, #1369:
URL: https://github.com/apache/hamilton/pull/1369
Add Apache license headers to source files.
These changes applied in **hamilton** and **ui** directories on code files.
## Changes
- Apache license headers added to source files.
## How I tested this
## Notes
## Checklist
- [x] PR has an informative and human-readable title (this will be pulled into the release notes)
- [x] Changes are limited to a single goal (no scope creep)
- [x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
- [ ] Any _change_ in functionality is tested
- [ ] New functions are documented (with a description, list of inputs, and expected output)
- [ ] Placeholder code is flagged / future TODOs are captured in comments
- [ ] Project documentation has been updated if adding/changing functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add license headers to source files #1360 [hamilton]
Posted by "skrawcz (via GitHub)" <gi...@apache.org>.
skrawcz commented on PR #1369:
URL: https://github.com/apache/hamilton/pull/1369#issuecomment-3125280012
Thanks @Gophersen -- I scanned these and they look good.
I'll let @pjfanning take a quick scan too.
I'll merge in a couple of days if I don't hear from PJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add license headers to source files #1360 [hamilton]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1369:
URL: https://github.com/apache/hamilton/pull/1369#discussion_r2235459974
##########
ui/backend/setup.py:
##########
@@ -1,3 +1,8 @@
+# /usr/bin/env python
+# -*- coding: utf-8 -*-
+
+"""The setup script."""
Review Comment:
can we have the license header before this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add license headers to source files #1360 [hamilton]
Posted by "Gophersen (via GitHub)" <gi...@apache.org>.
Gophersen commented on code in PR #1369:
URL: https://github.com/apache/hamilton/pull/1369#discussion_r2235563845
##########
ui/backend/setup.py:
##########
@@ -1,3 +1,8 @@
+# /usr/bin/env python
+# -*- coding: utf-8 -*-
+
+"""The setup script."""
Review Comment:
fixed. added between shebang(can not add before this) and coding comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add license headers to source files #1360 [hamilton]
Posted by "Gophersen (via GitHub)" <gi...@apache.org>.
Gophersen commented on code in PR #1369:
URL: https://github.com/apache/hamilton/pull/1369#discussion_r2235558929
##########
ui/sdk/setup.py:
##########
@@ -1,4 +1,5 @@
#!/usr/bin/env python
+# -*- coding: utf-8 -*-
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add license headers to source files #1360 [hamilton]
Posted by "skrawcz (via GitHub)" <gi...@apache.org>.
skrawcz merged PR #1369:
URL: https://github.com/apache/hamilton/pull/1369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add license headers to source files #1360 [hamilton]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1369:
URL: https://github.com/apache/hamilton/pull/1369#discussion_r2235445471
##########
dev_tools/language_server/tests/ls_setup.py:
##########
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
Review Comment:
you shouldn't add a source header here because there already is one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add license headers to source files #1360 [hamilton]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1369:
URL: https://github.com/apache/hamilton/pull/1369#discussion_r2235453923
##########
ui/sdk/setup.py:
##########
@@ -1,4 +1,5 @@
#!/usr/bin/env python
+# -*- coding: utf-8 -*-
Review Comment:
why move this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add license headers to source files #1360 [hamilton]
Posted by "Gophersen (via GitHub)" <gi...@apache.org>.
Gophersen commented on code in PR #1369:
URL: https://github.com/apache/hamilton/pull/1369#discussion_r2235547390
##########
dev_tools/language_server/tests/ls_setup.py:
##########
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
Review Comment:
You're right.
It's fixed, and I ran a script to check for any duplicate cases. I didn't find anything else besides this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org