[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3764: Fix optimizer regression with simplifying expressions in subquery filters

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #3764:
URL: https://github.com/apache/arrow-datafusion/pull/3764#discussion_r990644503


##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -144,6 +144,10 @@ impl Optimizer {
             Arc::new(DecorrelateWhereIn::new()),
             Arc::new(ScalarSubqueryToJoin::new()),
             Arc::new(SubqueryFilterToJoin::new()),
+            // simplify expressions does not simplify expressions in subqueries, so we

Review Comment:
   This PR just reverts the regression and adds a regression test, but I agree, would be better to handle it in `simplify_expressions`. I filed https://github.com/apache/arrow-datafusion/issues/3770 for this.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org