You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/29 00:34:28 UTC
[GitHub] [airflow] jharner11235 opened a new pull request, #26027: import_error_alert_emails
jharner11235 opened a new pull request, #26027:
URL: https://github.com/apache/airflow/pull/26027
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This adds functionality to notify a list of emails if a dag fails to import, and uses a variable in airflow.cfg to assign emails to be notified (instead of attempting to parse a broken dag for emails, which may at times be unviable)
closes: #10968
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jharner11235 commented on a diff in pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
jharner11235 commented on code in PR #26027:
URL: https://github.com/apache/airflow/pull/26027#discussion_r969140971
##########
airflow/dag_processing/processor.py:
##########
@@ -549,6 +549,17 @@ def update_import_errors(session: Session, dagbag: DagBag) -> None:
synchronize_session='fetch',
)
else:
+ emails: Set[str] = set(conf.get(section='email', key='dag_import_failure_email_to').split())
+ if emails and conf.getboolean(
+ section='email', key='email_on_dag_import_failure', fallback=True
+ ):
Review Comment:
suggestion taken but wrapped in commit with other changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #26027:
URL: https://github.com/apache/airflow/pull/26027#issuecomment-1343601476
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26027:
URL: https://github.com/apache/airflow/pull/26027#discussion_r965676289
##########
airflow/dag_processing/processor.py:
##########
@@ -549,6 +549,17 @@ def update_import_errors(session: Session, dagbag: DagBag) -> None:
synchronize_session='fetch',
)
else:
+ emails: Set[str] = set(conf.get(section='email', key='dag_import_failure_email_to').split())
+ if emails and conf.getboolean(
+ section='email', key='email_on_dag_import_failure', fallback=True
+ ):
+ try:
+ email_content = f"""File {filename} has failed to import due to:\n
+ <pre><code>{stacktrace}<code></pre>
Review Comment:
I'm not sure if the emails are plain text or html, though I assume plain text. So this doesn't seem right.
##########
airflow/dag_processing/processor.py:
##########
@@ -549,6 +549,17 @@ def update_import_errors(session: Session, dagbag: DagBag) -> None:
synchronize_session='fetch',
)
else:
+ emails: Set[str] = set(conf.get(section='email', key='dag_import_failure_email_to').split())
+ if emails and conf.getboolean(
+ section='email', key='email_on_dag_import_failure', fallback=True
+ ):
Review Comment:
```suggestion
emails: Set[str] = set(conf.get(section='email', key='dag_import_failure_email_to', fallback='').split())
if emails:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26027:
URL: https://github.com/apache/airflow/pull/26027#issuecomment-1229600275
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jharner11235 commented on a diff in pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
jharner11235 commented on code in PR #26027:
URL: https://github.com/apache/airflow/pull/26027#discussion_r969138091
##########
airflow/dag_processing/processor.py:
##########
@@ -549,6 +549,17 @@ def update_import_errors(session: Session, dagbag: DagBag) -> None:
synchronize_session='fetch',
)
else:
+ emails: Set[str] = set(conf.get(section='email', key='dag_import_failure_email_to').split())
+ if emails and conf.getboolean(
+ section='email', key='email_on_dag_import_failure', fallback=True
+ ):
+ try:
+ email_content = f"""File {filename} has failed to import due to:\n
+ <pre><code>{stacktrace}<code></pre>
Review Comment:
The emails show up and look as expected, it does seem to be HTML
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26027:
URL: https://github.com/apache/airflow/pull/26027#discussion_r965675154
##########
airflow/config_templates/config.yml:
##########
@@ -1477,6 +1477,20 @@
type: boolean
example: ~
default: "True"
+ - name: email_on_dag_import_failure
+ description: |
+ Whether email alerts should be sent when a dag fails to import
+ version_added: ~
+ type: boolean
+ example: ~
+ default: "True"
Review Comment:
We don't need a setting and a list of emails -- empty = don't email.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on PR #26027:
URL: https://github.com/apache/airflow/pull/26027#issuecomment-1232527514
I don't think it's cool to get alerts of broken dags every 5mins? WDYT @jharner11235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jharner11235 commented on pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
jharner11235 commented on PR #26027:
URL: https://github.com/apache/airflow/pull/26027#issuecomment-1233156286
> I don't think it's cool to get alerts of broken dags every 5mins? WDYT @jharner11235
I didn't get an alert every 5 minutes in any of my testing, given where the changes are made if alerts were being sent every 5mins then alerts would also be inserted into the database every 5mins, and I didn't see that occurring either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jharner11235 commented on a diff in pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
jharner11235 commented on code in PR #26027:
URL: https://github.com/apache/airflow/pull/26027#discussion_r969138240
##########
airflow/config_templates/config.yml:
##########
@@ -1477,6 +1477,20 @@
type: boolean
example: ~
default: "True"
+ - name: email_on_dag_import_failure
+ description: |
+ Whether email alerts should be sent when a dag fails to import
+ version_added: ~
+ type: boolean
+ example: ~
+ default: "True"
Review Comment:
oh yeah, that's fair. I'll make the adjustment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jharner11235 commented on pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
jharner11235 commented on PR #26027:
URL: https://github.com/apache/airflow/pull/26027#issuecomment-1229600827
I'm looking for some guidance in how to apply tests, I've yet to do any testing whatsoever near the scale present here and am quite lost.
And of course, anything goes on the already-written code as well :) happy to make any changes seen fit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #26027: import_error_alert_emails
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #26027: import_error_alert_emails
URL: https://github.com/apache/airflow/pull/26027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org