You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/01 01:49:20 UTC
[GitHub] [beam] Abacn opened a new pull request, #23914: Unify PerformanceTest metric dashboard naming
Abacn opened a new pull request, #23914:
URL: https://github.com/apache/beam/pull/23914
* Tests are named after 'IO Connector | Specifications | data size'.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1300921505
R: @aromanenko-dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1298890883
are you sure we won't need the configuration sections that you removed? are these autopopulated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23914: Unify PerformanceTest metric dashboard naming
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1298705122
R: @pabloem
Is there a way to show the preview? Previewed locally but without actual data because had no access to the database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1298888509
I am not familiar with this beyohnd the normal docs here: https://cwiki.apache.org/confluence/display/BEAM/Community+Metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #23914:
URL: https://github.com/apache/beam/pull/23914#discussion_r1010752911
##########
.test-infra/metrics/grafana/dashboards/perftests_metrics/Java_IO_IT_Tests_Dataflow.json:
##########
@@ -855,7 +855,7 @@
"yaxes": [
{
"$$hashKey": "object:403",
- "format": "s",
+ "format": "none",
Review Comment:
This figure plots count instead of time. Fixed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23914: Unify PerformanceTest metric dashboard naming
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1298706849
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1298887592
Java IO dashboard also checked. Ready for review now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1299111125
Thanks @pabloem . Replied above. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1301332624
thanks @Abacn - this LGTM : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #23914:
URL: https://github.com/apache/beam/pull/23914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1300902897
SparkReceiverIO Performance test has been merged. Rebasing and also changing the naming of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1298869707
Have setup a dumb influxdb database and verified the rendering:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23914: Unify PerformanceTest metric dashboard naming and series
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23914:
URL: https://github.com/apache/beam/pull/23914#issuecomment-1298894391
>
Yeah, thanks. I followed this documentation and get it working except I am not using the real data from influxDB. The screenshot above shows the results of some manipulated data.
The removed sections are combining read and write time in same plot as in Java. Currently they are plotted separately: http://104.154.241.245/d/gP7vMPqZz/python-io-it-tests-dataflow?orgId=1
I am working on adding more Python performance tests and this is a clean up for current frontend as a preclude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org