You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/23 15:04:27 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #3324: Sql test using derby doesn't start dev service and stored procedure is not working on derby db
JiriOndrusek opened a new pull request #3324:
URL: https://github.com/apache/camel-quarkus/pull/3324
fixes https://github.com/apache/camel-quarkus/issues/3260
- I used a workaround for an issue in quarkus - https://github.com/quarkusio/quarkus/issues/21639
- Test still can't be executed with external derby db (hance the condition on the stored procedure test). Problem is caused by the fact, that stored procedure is a java class, which has to be uploaded to the external derby instance. With devServices (which uses in-memory db) this is not a problem.
- I used different approach for the stored procedure test - creation of temp file. Which is sufficient for the test.
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #3324: Sql test using derby doesn't start dev service and stored procedure is not working on derby db
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #3324:
URL: https://github.com/apache/camel-quarkus/pull/3324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #3324: Sql test using derby doesn't start dev service and stored procedure is not working on derby db
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #3324:
URL: https://github.com/apache/camel-quarkus/pull/3324#issuecomment-977626726
@aldettinger I created a follow-up issue https://github.com/apache/camel-quarkus/issues/3327
At the first glance I think that it won't be possible to use external derby db for testing stored procedures, but I might be wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org