You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/09/30 23:55:31 UTC

Change in asterixdb[master]: .gitignore fix

Taewoo Kim has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1235

Change subject: .gitignore fix
......................................................................

.gitignore fix

 - Let .gitignore ignores the directories for the test results.

Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
---
M .gitignore
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/35/1235/1

diff --git a/.gitignore b/.gitignore
index 2dfbf0f..6c88169 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,9 +9,13 @@
 build
 asterixdb/asterix-opt
 asterixdb/asterix-app/src/test/resources/externallib
+asterixdb/asterix-app/opt_parserts/
+asterixdb/asterix-app/rttest/
+asterixdb/asterix-app/runtime_parserts/
 asterixdb/asterix-app/library
 asterixdb/asterix-app/data/csv/beer.csv
 asterixdb/asterix-installer/src/test/resources/clusterts/asterix-installer-*-SNAPSHOT-binary-assembly
+asterixdb/asterix-installer/ittest/
 *-coredump
 *.pyc
 *.iml

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>

Change in asterixdb[master]: .gitignore fix

Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Taewoo Kim has submitted this change and it was merged.

Change subject: .gitignore fix
......................................................................


.gitignore fix

 - Let .gitignore ignores the directories for the test results.

Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1235
Reviewed-by: Ian Maxon <im...@apache.org>
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
M .gitignore
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Ian Maxon: Looks good to me, approved
  Jenkins: Verified; No violations found



diff --git a/.gitignore b/.gitignore
index 2dfbf0f..6c88169 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,9 +9,13 @@
 build
 asterixdb/asterix-opt
 asterixdb/asterix-app/src/test/resources/externallib
+asterixdb/asterix-app/opt_parserts/
+asterixdb/asterix-app/rttest/
+asterixdb/asterix-app/runtime_parserts/
 asterixdb/asterix-app/library
 asterixdb/asterix-app/data/csv/beer.csv
 asterixdb/asterix-installer/src/test/resources/clusterts/asterix-installer-*-SNAPSHOT-binary-assembly
+asterixdb/asterix-installer/ittest/
 *-coredump
 *.pyc
 *.iml

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>

Change in asterixdb[master]: .gitignore fix

Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has posted comments on this change.

Change subject: .gitignore fix
......................................................................


Patch Set 2:

For some reason they weren't though. I didn't know we had finally fixed that issue however, I guess that explains why they were removed. Maybe the files that were showing up were from tests on an old branch?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: .gitignore fix

Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Taewoo Kim has posted comments on this change.

Change subject: .gitignore fix
......................................................................


Patch Set 2:

Oh ...

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: .gitignore fix

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: .gitignore fix
......................................................................


Patch Set 1:

Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/809/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: .gitignore fix

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: .gitignore fix
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2866/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: .gitignore fix

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: .gitignore fix
......................................................................


Patch Set 1:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/809/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: .gitignore fix

Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has posted comments on this change.

Change subject: .gitignore fix
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: .gitignore fix

Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.

Change subject: .gitignore fix
......................................................................


Patch Set 2:

You don't need to add those -- they should all go to target/ now...

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: .gitignore fix

Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.

Change subject: .gitignore fix
......................................................................


Patch Set 2:

You just need to manually remove them once, then they should never appear.

The ones you see are leftovers from your builds for earlier versions.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: .gitignore fix

Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.

Change subject: .gitignore fix
......................................................................


Patch Set 2:

>> Maybe the files that were showing up were from tests on an old branch?

That could be the case...  A good reason to move to the latest master:-)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1235
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If83bb49719bd41d5f71fefc785e4bcfae99d2d06
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No