[GitHub] [nifi] NissimShiman commented on pull request #6414: NIFI-9878 fix for hanging client thread with handshake does not complete

[GitBox <gi...@apache.org>]

NissimShiman commented on PR #6414:
URL: https://github.com/apache/nifi/pull/6414#issuecomment-1246912052

   Very nice work @jlshoem 
   
   Tested flow as in jira ticket before and after code changes were done.  Set up ListenHTTP (with random port number) and used that same port for server port for DistributedMapCacheClientService to mimic issue.
   
   Issue was seen as described before code fixes and issue has been resolved with code fix.  
   
   After handshake timeout, flowfiles will go now to failure relationship with handshake timeout error in logs as opposed to accumulating on input queue with no message.  Also after its timeout period, PutDistributedMapCache can now be turned off normally without need to force terminate
   
   Also, additional/similar issue seen with shutting down DistributedMapCacheClientService before code fix (as it never truly shutdown - it went into disabling state - nifi restart was needed to fully disable it).  After code fix DistributedMapCacheClientService will fully shutdown after the handshake timeout even when pointing to the "wrong" port number.  So this is a really nice side effect of this effort.
   
   It would be nice if DistributedMapCacheClientService would never even start if it was pointing to a port that it shouldn't be, as that would be useful in some of the use cases of this ticket, but that is pushing ticket scope.  That can be another ticket 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org