[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29672: [SPARK-32818][SQL] Make `CONVERT_METASTORE_PARQUET` and `CONVERT_METASTORE_ORC` session level configurable

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #29672:
URL: https://github.com/apache/spark/pull/29672#discussion_r486135994



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2560,6 +2560,33 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
       }
     }
   }
+
+  test("SPARK-32818: make metastore convert session level configurable") {

Review comment:
       > Does this test fail w/o this patch? Looks it can pass even in master.
   
   I miss the point that SQLConf.get is related to current thread's SparkSession.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org