You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Kirk Lund <kl...@apache.org> on 2016/10/19 22:51:10 UTC

IntelliJ and Eclipse formatters

Should we be using these formatters instead of the formatters under /etc in
Geode?

Google Java Style Eclipse Formatter...
https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml

Google Java Style IntelliJ Formatter...
https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml

-Kirk

Re: IntelliJ and Eclipse formatters

Posted by Kirk Lund <kl...@apache.org>.

Sounds good!


On Wed, Oct 19, 2016 at 4:04 PM, Jared Stewart <js...@pivotal.io> wrote:

> I will submit a pr later this week to enable spotless and switch to these
> templates. The intellij one needs to be updated however. It's give years
> old and doesnt work with recent versions of intellij. Multiple PRs have
> been made to update to fix this, but Google has not yet accepted one. I'd
> like to compare the options submitted and choose one of those.
>
> On Oct 19, 2016 3:55 PM, "Kirk Lund" <kl...@apache.org> wrote:
>
> > Should we be using these formatters instead of the formatters under /etc
> in
> > Geode?
> >
> > Google Java Style Eclipse Formatter...
> > https://github.com/google/styleguide/blob/gh-pages/
> > eclipse-java-google-style.xml
> >
> > Google Java Style IntelliJ Formatter...
> > https://github.com/google/styleguide/blob/gh-pages/
> > intellij-java-google-style.xml
> >
> > -Kirk
> >
>

Re: IntelliJ and Eclipse formatters

Posted by Jared Stewart <js...@pivotal.io>.

I will submit a pr later this week to enable spotless and switch to these
templates. The intellij one needs to be updated however. It's give years
old and doesnt work with recent versions of intellij. Multiple PRs have
been made to update to fix this, but Google has not yet accepted one. I'd
like to compare the options submitted and choose one of those.

On Oct 19, 2016 3:55 PM, "Kirk Lund" <kl...@apache.org> wrote:

> Should we be using these formatters instead of the formatters under /etc in
> Geode?
>
> Google Java Style Eclipse Formatter...
> https://github.com/google/styleguide/blob/gh-pages/
> eclipse-java-google-style.xml
>
> Google Java Style IntelliJ Formatter...
> https://github.com/google/styleguide/blob/gh-pages/
> intellij-java-google-style.xml
>
> -Kirk
>