You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/02/01 18:30:33 UTC
[GitHub] couchdb-fauxton pull request: react migration: convert styletests ...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/636
react migration: convert styletests to react
to test, add `{ "name": "styletests" },` to the
settings.json.default file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton styletests-react
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #636
----
commit 9993382629a86c50d61c31e4b65f62f0787eaee4
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-02-01T14:21:40Z
react migration: convert styletests to react
to test, add `{ "name": "styletests" },` to the
settings.json.default file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: react migration: convert styletests ...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: react migration: convert styletests ...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/636#discussion_r51675339
--- Diff: app/addons/styletests/routes.js ---
@@ -13,28 +13,31 @@
define([
"app",
"api",
- "addons/styletests/views"
+ 'addons/styletests/styletests.react'
],
-function (app, FauxtonAPI, Views) {
+function (app, FauxtonAPI, StyleTests) {
var TestRouteObject = FauxtonAPI.RouteObject.extend({
layout: "one_pane",
routes: {
"tests": "initialize"
},
+
selectedHeader: 'theme tests',
+
crumbs:[],
+
apiUrl: function () {
return false;
},
+
initialize: function () {
- this.setView("#dashboard-content", new Views.tests({}));
+ console.log("init");
--- End diff --
Should be dropped.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: react migration: convert styletests ...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/636#issuecomment-181437206
merged as 378d80e6017542d3cb33a763ed3497a1bf9c7f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: react migration: convert styletests ...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/636#issuecomment-178985506
Looks good, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---