You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kevin Wilfong (Created) (JIRA)" <ji...@apache.org> on 2012/04/17 19:43:22 UTC
[jira] [Created] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress
always uses the same port
TestRemoteHiveMetaStoreIpAddress always uses the same port
----------------------------------------------------------
Key: HIVE-2959
URL: https://issues.apache.org/jira/browse/HIVE-2959
Project: Hive
Issue Type: Test
Reporter: Kevin Wilfong
Assignee: Kevin Wilfong
TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.
There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress
always uses the same port
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257148#comment-13257148 ]
Hudson commented on HIVE-2959:
------------------------------
Integrated in Hive-trunk-h0.21 #1382 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1382/])
HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port
(Kevin Wilfong via Ashutosh Chauhan)
Summary:
https://issues.apache.org/jira/browse/HIVE-2959
TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free
port using Java's ServerSocket class.
TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if
another process happens to be using that port, the tests cannot succeed.
There seems to be a standard way of finding a free port using Java's
ServerSocket class, this should be used instead.
Test Plan: Ran TestRemoteHiveMetaStoreIpAddress and
TestRemoteUGIHiveMetaStoreIpAddress, the two tests which would be affected by
this change. I verified they passed and did not use port 39083.
Reviewers: JIRA, njain, ashutoshc
Reviewed By: ashutoshc
Differential Revision: https://reviews.facebook.net/D2841 (Revision 1327591)
Result = SUCCESS
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327591
Files :
* /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
> TestRemoteHiveMetaStoreIpAddress always uses the same port
> ----------------------------------------------------------
>
> Key: HIVE-2959
> URL: https://issues.apache.org/jira/browse/HIVE-2959
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.10
>
> Attachments: HIVE-2959.D2841.1.patch
>
>
> TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.
> There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress
always uses the same port
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256088#comment-13256088 ]
Phabricator commented on HIVE-2959:
-----------------------------------
ashutoshc has accepted the revision "HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port".
+1 will commit if tests pass.
REVISION DETAIL
https://reviews.facebook.net/D2841
BRANCH
svn
> TestRemoteHiveMetaStoreIpAddress always uses the same port
> ----------------------------------------------------------
>
> Key: HIVE-2959
> URL: https://issues.apache.org/jira/browse/HIVE-2959
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2959.D2841.1.patch
>
>
> TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.
> There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress
always uses the same port
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256734#comment-13256734 ]
Phabricator commented on HIVE-2959:
-----------------------------------
kevinwilfong has committed the revision "HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port".
Change committed by hashutosh.
REVISION DETAIL
https://reviews.facebook.net/D2841
COMMIT
https://reviews.facebook.net/rHIVE1327591
> TestRemoteHiveMetaStoreIpAddress always uses the same port
> ----------------------------------------------------------
>
> Key: HIVE-2959
> URL: https://issues.apache.org/jira/browse/HIVE-2959
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.10
>
> Attachments: HIVE-2959.D2841.1.patch
>
>
> TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.
> There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress
always uses the same port
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2959:
--------------------------------
Status: Patch Available (was: Open)
> TestRemoteHiveMetaStoreIpAddress always uses the same port
> ----------------------------------------------------------
>
> Key: HIVE-2959
> URL: https://issues.apache.org/jira/browse/HIVE-2959
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2959.D2841.1.patch
>
>
> TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.
> There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress
always uses the same port
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2959:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.10
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks, Kevin!
> TestRemoteHiveMetaStoreIpAddress always uses the same port
> ----------------------------------------------------------
>
> Key: HIVE-2959
> URL: https://issues.apache.org/jira/browse/HIVE-2959
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.10
>
> Attachments: HIVE-2959.D2841.1.patch
>
>
> TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.
> There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress
always uses the same port
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2959:
------------------------------
Attachment: HIVE-2959.D2841.1.patch
kevinwilfong requested code review of "HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2959
TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free port using Java's ServerSocket class.
TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.
There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2841
AFFECTED FILES
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6435/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> TestRemoteHiveMetaStoreIpAddress always uses the same port
> ----------------------------------------------------------
>
> Key: HIVE-2959
> URL: https://issues.apache.org/jira/browse/HIVE-2959
> Project: Hive
> Issue Type: Test
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2959.D2841.1.patch
>
>
> TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed.
> There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira